MetaMask Mobile Compatibility Checklist #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can someone vet the Alternative UI Library section please before merging? |
Gudahtt
reviewed
Jul 1, 2020
|
@omnat Mind if we hop on a quick call tomorrow? |
…to aakers-mobile-docs
…to aakers-mobile-docs
|
Adding @estebanmino for review as well :) |
|
Quick ping, just wanted to know if this can be approved and merged? 🙂 |
rekmarks
requested changes
Jul 31, 2020
There was a problem hiding this comment.
@BboyAkers I'll preface this review by stating that, as a prose editor, I'm a stickler.
The content is overall good, it just requires a significant amount of polish. Please let me know if you have any questions at all!
rekmarks
changed the title
|
@rekmarks Thanks a ton!!! I just pushed all the changes you requested 🙂 |
rekmarks
approved these changes
Aug 5, 2020
There was a problem hiding this comment.
LGTM, nice work @BboyAkers, and congratulations on the big life moves!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
MetaMask Mobile Compatibility Checklist section on the Dapp Compatibility page.