-
-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MetaMask Mobile Compatibility Checklist #136
Conversation
Can someone vet the Alternative UI Library section please before merging? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @BboyAkers ! Couple of comments
@omnat Mind if we hop on a quick call tomorrow? |
…to aakers-mobile-docs
…to aakers-mobile-docs
Adding @estebanmino for review as well :) |
Quick ping, just wanted to know if this can be approved and merged? 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BboyAkers I'll preface this review by stating that, as a prose editor, I'm a stickler.
The content is overall good, it just requires a significant amount of polish. Please let me know if you have any questions at all!
@rekmarks Thanks a ton!!! I just pushed all the changes you requested 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work @BboyAkers, and congratulations on the big life moves!
Added the
MetaMask Mobile Compatibility Checklist section on the Dapp Compatibility page.