Bring lint pipeline up to date w/ module template #28
Conversation
We would like to bump the development Node version to 20, but this requires bumping `eslint-plugin-jsdoc`. The minimum version of this package that supports Node 20 is 43.0.0, but this version expects a minimum Node version of 16. This commit bumps the minimum Node version to 16 and drops 12 and 14 from the CI matrix.
This is a requirement for bumping ESLint packages, since `@metamask/eslint-config-typescript` now enables type-aware rules. Unfortunately, the current TypeScript config file excludes test files, so running `yarn lint` would produce an error once those packages were upgraded.
- Upgrade all ESLint packages to match the module template - Upgrade `@metamask/auto-changelog` - Reformat changelog via Prettier - Add `depcheck` and `.depcheckrc.json`, and run it via `yarn lint`
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is new author?A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package. Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
@metamask/auto-changelogdepcheckand.depcheckrc.json, and run it viayarn lint