Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring lint pipeline up to date w/ module template #28

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Bring lint pipeline up to date w/ module template #28

wants to merge 4 commits into from

Commits on Mar 21, 2024

  1. Bump min Node version to 16; drop 12 and 14 

    We would like to bump the development Node version to 20, but this
requires bumping `eslint-plugin-jsdoc`. The minimum version of this
package that supports Node 20 is 43.0.0, but this version expects a
minimum Node version of 16. This commit bumps the minimum Node version
to 16 and drops 12 and 14 from the CI matrix.
    @mcmire
    mcmire committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    c9eab07 View commit details
    Browse the repository at this point in the history

  2. Extract build-specific TypeScript configuration 

    This is a requirement for bumping ESLint packages, since
`@metamask/eslint-config-typescript` now enables type-aware rules.
Unfortunately, the current TypeScript config file excludes test files,
so running `yarn lint` would produce an error once those packages were
upgraded.
    @mcmire
    mcmire committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    ea225d0 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'split-tsconfig' into upgrade-lint-pipeline

    @mcmire
    mcmire committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    4c4b4cf View commit details
    Browse the repository at this point in the history

  4. Bring lint pipeline up to date w/ module template 

    - Upgrade all ESLint packages to match the module template
- Upgrade `@metamask/auto-changelog`
  - Reformat changelog via Prettier
- Add `depcheck` and `.depcheckrc.json`, and run it via `yarn lint`
    @mcmire
    mcmire committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    99bd1b5 View commit details
    Browse the repository at this point in the history