Remove variation argument

Fix unit test. Fix storybook.
MetaMask · Mar 13, 2024 · 0dc6096 · 0dc6096
1 parent 1241336
commit 0dc6096
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/ui/components/ui/identicon/identicon.component.js b/ui/components/ui/identicon/identicon.component.js
@@ -57,6 +57,9 @@ export default class Identicon extends Component {
      * User preferred IPFS gateway
      */
     ipfsGateway: PropTypes.string,
+    /**
+     * Watched NFT contract data keyed by address
+     */
     watchedNftContracts: PropTypes.object,
   };
 
@@ -73,6 +76,7 @@ export default class Identicon extends Component {
     useBlockie: false,
     alt: '',
     tokenList: {},
+    watchedNftContracts: {},
   };
 
   renderImage() {

diff --git a/ui/components/ui/identicon/identicon.stories.js b/ui/components/ui/identicon/identicon.stories.js
@@ -22,6 +22,7 @@ export default {
     imageBorder: { control: 'boolean' },
     useTokenDetection: { control: 'boolean' },
     tokenList: { control: 'object' },
+    watchedNftContracts: { control: 'object' },
   },
 };
 

diff --git a/ui/hooks/useDisplayName.ts b/ui/hooks/useDisplayName.ts
@@ -10,23 +10,17 @@ import { useFirstPartyContractName } from './useFirstPartyContractName';
  *
  * @param value
  * @param type
- * @param variation
  * @returns An object with two properties:
  * - `name` {string|null} - The display name, if it can be resolved, otherwise null.
  * - `hasPetname` {boolean} - True if there is a petname for the given address.
  */
 export function useDisplayName(
   value: string,
   type: NameType,
-  variation?: string,
 ): { name: string | null; hasPetname: boolean } {
-  const nameEntry = useName(value, type, variation);
+  const nameEntry = useName(value, type);
 
-  const firstPartyContractName = useFirstPartyContractName(
-    value,
-    type,
-    variation,
-  );
+  const firstPartyContractName = useFirstPartyContractName(value, type);
 
   const contractName = useSelector((state) =>
     (getMemoizedMetadataContractName as any)(state, value),

diff --git a/ui/pages/confirmations/send/send-content/add-recipient/add-recipient.container.test.js b/ui/pages/confirmations/send/send-content/add-recipient/add-recipient.container.test.js
@@ -10,6 +10,7 @@ jest.mock('react-redux', () => ({
 }));
 
 jest.mock('../../../../../selectors', () => ({
+  ...jest.requireActual('../../../../../selectors'),
   getAddressBook: (s) => [{ name: `mockAddressBook:${s}` }],
   getAddressBookEntry: (s) => `mockAddressBookEntry:${s}`,
   getInternalAccountsSortedByKeyring: () => [