Skip to content

Commit

Permalink
fix: desktop build (#24478)
Browse files Browse the repository at this point in the history
## **Description**

REDESIGN_APPROVAL_TYPES and REDESIGN_TRANSACTION_TYPES should not be
code fenced by blockaid. This is causing the desktop build to fail
because it does not have the blockaid feature enable.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24478?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
cryptotavares committed May 10, 2024
1 parent 3c2d792 commit 0fdfdac
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions app/scripts/lib/createRPCMethodTrackingMiddleware.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,12 @@ import {

///: BEGIN:ONLY_INCLUDE_IF(blockaid)
import { SIGNING_METHODS } from '../../../shared/constants/transaction';

import { getBlockaidMetricsProps } from '../../../ui/helpers/utils/metrics';
///: END:ONLY_INCLUDE_IF
import {
REDESIGN_APPROVAL_TYPES,
REDESIGN_TRANSACTION_TYPES,
} from '../../../ui/pages/confirmations/utils/confirm';
import { getBlockaidMetricsProps } from '../../../ui/helpers/utils/metrics';
///: END:ONLY_INCLUDE_IF
import { getSnapAndHardwareInfoForMetrics } from './snap-keyring/metrics';

/**
Expand Down

0 comments on commit 0fdfdac

Please sign in to comment.