Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approve screen renders before token data has been retrieved #10088

Closed
Gudahtt opened this issue Dec 16, 2020 · 4 comments · Fixed by #10606
Closed

Approve screen renders before token data has been retrieved #10088

Gudahtt opened this issue Dec 16, 2020 · 4 comments · Fixed by #10606
Assignees
Labels
Sev3-low Low severity; minimal to no impact upon users type-bug

Comments

@Gudahtt
Copy link
Member

Gudahtt commented Dec 16, 2020

Describe the bug
The Approve screen will render once before the token data has been loaded, resulting in a flash of "empty" content and a bunch of console errors (which are then reported to Sentry).

Steps to reproduce (REQUIRED)

  1. Go to https://metamask.github.io/test-dapp/
  2. Click on 'Create token", and approve the deploy transaction (ideally on a testnet)
  3. Wait for the transaction to be confirmed
  4. Click "Approve tokens"
  5. The notification window should pop up, showing the Approve confirmation screen. It will render, flash white, then re-render with the proper values. The console will show errors.

Expected behavior
The Approve screen should never render with empty content nor emit console errors. Instead there should be a loading screen until the page is ready to be rendered.

Browser details (please complete the following information):

  • OS: Ubuntu
  • Browser: tested in latest Chrome and Firefox
  • MetaMask Version: v8.1.9 (though this dates back at least to v8.0.0)
@Gudahtt Gudahtt added type-bug Sev3-low Low severity; minimal to no impact upon users labels Dec 16, 2020
@sentry-io
Copy link

sentry-io bot commented Dec 16, 2020

Sentry issue: METAMASK-GNCR

@sentry-io
Copy link

sentry-io bot commented Dec 16, 2020

Sentry issue: METAMASK-GNCQ

@sentry-io
Copy link

sentry-io bot commented Dec 16, 2020

Sentry issue: METAMASK-GP4F

@sentry-io
Copy link

sentry-io bot commented Dec 16, 2020

Sentry issue: METAMASK-GP4E

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sev3-low Low severity; minimal to no impact upon users type-bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants