Avoid rendering Approve screen before token data has been retrieved. #10606
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10088
Explanation:
Issue: The
approve screen
gets rendered before the token Data was retrieved, resulting in errors in the console and white screen flashing before the original page renders.Fix: The fix is to check for the
tokenSymbol
value before rendering the<ConfirmTransactionBase/>
fromconfirm-approve.container.js
, which in turn calls<ConfirmApproveContent/>
. The check is usingtokenSymbol
as it is the only token data that is being used in the first rendering of<ConfirmApproveContent/>
Manual testing steps:
Create token
, and approve the deploy transaction (ideally on a testnet)Approve tokens