Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetaMask / metamask-extension Build error on Windows10 #12168

Closed
AsadullahSoomro opened this issue Sep 21, 2021 · 4 comments
Closed

MetaMask / metamask-extension Build error on Windows10 #12168

AsadullahSoomro opened this issue Sep 21, 2021 · 4 comments
Labels
area-buildSystem related to our build system

Comments

@AsadullahSoomro
Copy link

Currently, I am trying to build Metamask on windows 10 using Nodejs v14.17.6

yarn run v1.22.11
$ lavamoat development/build/index.js
(Error#1)

Error#1: LavaMoat - required package not in whitelist: package "@gulp-sourcemaps\map-sources" requested "through2" as "through2"
at requireRelative (LavaMoat/core/kernel:414:15)
at requireRelativeWithContext (LavaMoat/core/kernel:366:16)
at Object.eval (\work\metamask-extension\node_modules@gulp-sourcemaps\map-sources\index.js:4:15)
at internalRequire (LavaMoat/core/kernel:353:25)
at requireRelative (LavaMoat/core/kernel:394:27)
at requireRelativeWithContext (LavaMoat/core/kernel:366:16)
at Object.eval (\work\metamask-extension\node_modules\gulp-sourcemaps\index.js:7:15)
at internalRequire (LavaMoat/core/kernel:353:25)
at requireRelative (LavaMoat/core/kernel:394:27)
at requireRelativeWithContext (LavaMoat/core/kernel:366:16)

OS: Windows 10
MetaMask Version: 10.1.0
Node v14.17.6
Yarn v1.22.11
error screenshot here:
image

@ryanml
Copy link
Contributor

ryanml commented Sep 21, 2021

@AsadullahSoomro - did you run yarn setup or just yarn?

@AsadullahSoomro
Copy link
Author

@AsadullahSoomro - did you run yarn setup or just yarn?
@ryanml
yes, sir,it is running but right now another exception coming when I am just trying to clone the metamask using

MetaMask/metamask-extension from github

I am just following the docs, but ended up in error when access the extension via browser
Uncaught ReferenceError: LavaPack is not defined
context
background.html

I have tried to get it resolve but unable to find any clue
image

@darkwing darkwing added the area-buildSystem related to our build system label Oct 6, 2021
@jonathansampson
Copy link

jonathansampson commented Oct 11, 2021

Adding my name to the list of people experiencing these issues.

The yarn dist command fails entirely for me (I ran yarn setup prior):

image

The yarn start command succeeds, but I too see a slew of Uncaught ReferenceError: LavaPack is not defined errors on the background page.

A bit of bisecting reveals f196c9f to be the first bad commit (with regards to building on Windows). I suppose it's not surprising :)

The issue could be with the escaping of back-slashes in package names:

Note here how @babel/core is not escaped when requested as a package:

image

But it is escaped when its own packages are requested:

image

@Gudahtt
Copy link
Member

Gudahtt commented Oct 13, 2021

Thanks for the report! This is a duplicate of #10748. Please follow that issue for updates.

@Gudahtt Gudahtt closed this as completed Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-buildSystem related to our build system
Projects
None yet
Development

No branches or pull requests

6 participants
@darkwing @jonathansampson @Gudahtt @ryanml @AsadullahSoomro and others