Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding tasks for MV3 test build #15133

Merged
merged 19 commits into from Jul 13, 2022
Merged

Adding tasks for MV3 test build #15133

merged 19 commits into from Jul 13, 2022

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Jul 4, 2022 •
edited

Adding build tasks for MV3

Fixes: #15127

@jpuri jpuri requested a review from segun July 4, 2022 12:01
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [62883bf]
Page Load Metrics (1648 ± 67 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint8011597105
domContentLoaded15262074164112259
load15432170164813967
domInteractive15262074164112259

@metamaskbot
Copy link
Collaborator

Builds ready [6b3344f]
Page Load Metrics (1653 ± 41 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint811603183326157
domContentLoaded1538184816477737
load1538185416538541
domInteractive1538184816477737

@jpuri jpuri dismissed a stale review via e182bf5 July 5, 2022 05:08
@metamaskbot
Copy link
Collaborator

Builds ready [e6d6e09]
Page Load Metrics (1727 ± 44 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint851901196391188
domContentLoaded1584190817158943
load1585190817279144
domInteractive1584190817158943

@metamaskbot
Copy link
Collaborator

Builds ready [730538a]
Page Load Metrics (1699 ± 36 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint811169994
domContentLoaded1599189316887737
load1599189316997636
domInteractive1599189316887737

@jpuri jpuri marked this pull request as ready for review July 5, 2022 15:07
@jpuri jpuri requested review from a team and kumavis as code owners July 5, 2022 15:07
@jpuri jpuri requested a review from danjm July 5, 2022 15:09
kumavis
kumavis previously requested changes Jul 5, 2022
View reviewed changes
Copy link
Member

@kumavis kumavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add these tests to ci

@jpuri jpuri requested a review from kumavis July 6, 2022 09:04
@jpuri
Copy link
Contributor Author

jpuri commented Jul 6, 2022

add these tests to ci

@kumavis : PR is updated for this.

@metamaskbot
Copy link
Collaborator

Builds ready [5a36558]
Page Load Metrics (2129 ± 57 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1092149343571274
domContentLoaded19192454211412158
load19192470212911957
domInteractive19192454211412158

@metamaskbot
Copy link
Collaborator

Builds ready [c3e367b]
Page Load Metrics (1994 ± 146 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint902289238472227
domContentLoaded161624591970309148
load161624591994303146
domInteractive161624591970309148

@metamaskbot
Copy link
Collaborator

Builds ready [91ddb07]
Page Load Metrics (1635 ± 25 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint8412394105
domContentLoaded1553170516254421
load1556178416355225
domInteractive1553170516254421

segun
segun approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@segun segun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metamaskbot
Copy link
Collaborator

Builds ready [09ac931]
Page Load Metrics (1759 ± 69 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint911818192373179
domContentLoaded15932261175414871
load15932261175914469
domInteractive15932261175414871

@hilvmason hilvmason added the PR - P1 identifies PRs deemed priority for Extension team label Jul 12, 2022
@jpuri jpuri dismissed kumavis’s stale review July 13, 2022 23:34

Review feedback is addressed.

@jpuri jpuri merged commit aeb0147 into develop Jul 13, 2022
@jpuri jpuri deleted the mv3_test_build branch July 13, 2022 23:34
@github-actions github-actions bot locked and limited conversation to collaborators Jul 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@segun segun segun approved these changes

@darkwing darkwing darkwing approved these changes

@danjm danjm Awaiting requested review from danjm

@kumavis kumavis Awaiting requested review from kumavis kumavis is a code owner

Assignees
No one assigned
Labels
PR - P1 identifies PRs deemed priority for Extension team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build changes for MV3 e2e tests
6 participants
@jpuri @metamaskbot @segun @darkwing @kumavis @hilvmason