[Bug]: Doing a single transaction with fees configured different from saved fees results in forgetting of saved fees.

[MicahZoltu]

Describe the bug

I submit all of my transactions with the same max fee and priority fee, which I have configured in MetaMask's advanced gas fee UI and saved via the checkbox in that UI that allows me to remember my settings. This works great under normal conditions, but if I want to do a single transaction with different fees (e.g., higher priority fee than normal) it results in me losing my saved configuration, even though I unchecked the box to "save these fees as default".

Steps to reproduce

1. Submit a transaction with custom fees and check the box for saving fee configuration as defaults.
2. Submit another transaction and notice that it uses the saved fees (expected behavior).
3. Submit a third transaction, but for this one edit the custom fees and uncheck the box to save the fees.
4. Submit a fourth transaction and notice that it has reverted to using MetaMask recommended fees rather than the ones I saved as default in step (1).

Error messages or log output

No response

Version

10.22.2

Build type

None

Browser

Firefox

Operating system

Windows

Hardware wallet

No response

Additional context

This wouldn't be a problem except that BitPay still hasn't updated their stuff to work with EIP-1559, and their contracts are setup to hard fail if the user doesn't have a sufficiently high GAS_PRICE (effective gas price). This is incredibly frustrating and I have complained repeatedly to BitPay about it but they don't seem to care. However, since they are one of the leading payment processors, I think it is important that it is minimally painful to use them while also using MetaMask.

I think this is a legitimate bug even if not for BitPay's stupidity, I bring it up only to help with prioritization.

[bschorchit]

Thank you for the detailed report, @MicahZoltu! We'll look into it :)

[bschorchit]

Sorry for the late response on this @MicahZoltu ! But we were not able to reproduce it. It might be a confusion with step 3.
You mentioned 3. Submit a third transaction, but for this one edit the custom fees and uncheck the box to save the fees. but as we've tested the checkbox auto-uncheck if you edit the values so you don't need to manually uncheck it.

Would you mind re-testing it on your side and letting us know? Thank you!

[MicahZoltu]

I'm still experiencing this issue on 10.23.3.

If I have previously saved fees I see

If I click the "Advanced > Edit" button above the gas cost estimate I see something like this:

I then uncheck that box and click "Save".

Then on step 4 I see this:

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.