Update Button prop name type to variant

[georgewrmarshall]

Description

Currently the prop to change the button style: PRIMARY, SECONDARY, LINK etc for the component-library Button component is called type. It would be more consistent with the rest of our components of this prop was renamed to variant

There should be only a few instances of the Button component from the ui/components/component-library folder so it should be ok to update all in one PR

Technical Details

• Update const BUTTON_TYPES to BUTTON_VARIANT
• Update all instances of type prop to variant for the Button component
• Update all storybook stories and documentation
• Update all tests
• Update all instances of Button used in the code base

Acceptance Criteria

• All instances of the type prop have been updated to variant
• All storybook stories and docs have been updated accordingly
• PR contains before/after screenshots of every instance of the Button that has been updated

[hakeemullahjan]

@georgewrmarshall I would love to take this. Please can you assign this to me?

[georgewrmarshall]

Hey @hakeemullahjan, thanks for your interest. Assigned. Looking forward to your PR. Thanks!

[dhruvv173]

Hi @georgewrmarshall @hakeemullahjan, I'd like to assist to this issue

[georgewrmarshall]

Fixed by #18774