Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache identicons #197

Closed
danfinlay opened this issue May 20, 2016 · 0 comments
Closed

Cache identicons #197

danfinlay opened this issue May 20, 2016 · 0 comments
Assignees
@danfinlay
Labels
type-enhancement
Milestone
Whisper Beta

Comments

@danfinlay
Copy link
Contributor

Right now we generate identicons on demand to render. Instead we should be caching the svg strings we generate, so they can be reused.
@danfinlay danfinlay added this to the Public Beta milestone May 20, 2016
@danfinlay danfinlay added the ready label Jun 6, 2016
@danfinlay danfinlay self-assigned this Jun 6, 2016
danfinlay added a commit that referenced this issue Jun 6, 2016
@danfinlay
Cache identicons
d5c378b 
Fixes #197

Also as a side effect, by creating this `iconFactory.cache` object, we have a convenient place for specifying stock icons for known contracts!

We can just hard-code image addresses in the `ui/lib/icon-factory.js` cache instantiation, and those values will be injected into the identicon image tag `src` attributes.
@danfinlay danfinlay mentioned this issue Jun 6, 2016
Merged
yqrashawn added a commit to yqrashawn/conflux-portal that referenced this issue Aug 31, 2020
@yqrashawn
Merge pull request MetaMask#197 from Conflux-Chain/master
3ba83e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danfinlay danfinlay

Labels
type-enhancement
Projects
None yet
Milestone
Whisper Beta
Development

No branches or pull requests
2 participants
@danfinlay @2-am-zzz