Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text formatting in sign dialog old vs new UI #4176

Closed
TrejGun opened this issue May 3, 2018 · 3 comments · Fixed by #4617
Closed

text formatting in sign dialog old vs new UI #4176

TrejGun opened this issue May 3, 2018 · 3 comments · Fixed by #4617
Assignees
Labels
area-UI Relating to the user interface. good first issue Good for newcomers type-enhancement

Comments

@TrejGun
Copy link
Contributor

TrejGun commented May 3, 2018

in old UI there were line breaks in sign dialog

const message = "Text \n\n\n text";
window.web3.currentProvider.sendAsync({
      method: "personal_sign",
      params: [message, from],
      from
}, () => {});

screen shot 2018-05-03 at 11 24 29

but in new UI its missing

screen shot 2018-05-03 at 11 24 52

may be you have to add

    white-space: pre-line;
@TrejGun
Copy link
Contributor Author

TrejGun commented May 20, 2018

also non-latin chars are not displaying properly
this is Chinese language

screen shot 2018-05-20 at 17 23 27

@bdresser bdresser added type-enhancement P3-soon area-UI Relating to the user interface. labels Jun 1, 2018
@TrejGun
Copy link
Contributor Author

TrejGun commented Jun 15, 2018

probaly chinese language is not your issue

screen shot 2018-06-15 at 17 45 55

const message = "0x" + Buffer.from("言", "utf8").toString("hex");

works just fine

@TrejGun
Copy link
Contributor Author

TrejGun commented Jun 20, 2018

toHex was fixed by web3 team in this commit
web3/web3.js@bd6a890

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-UI Relating to the user interface. good first issue Good for newcomers type-enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants