Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix white spaces in signature #4617

Merged
merged 1 commit into from
Jul 5, 2018
Merged

fix white spaces in signature #4617

merged 1 commit into from
Jul 5, 2018

Conversation

TrejGun
Copy link
Contributor

@TrejGun TrejGun commented Jun 20, 2018

fixes #4176

@danjm
Copy link
Contributor

danjm commented Jul 3, 2018

@TrejGun Can you include a screenshot that shows what this looks like after your fix? Thanks

@TrejGun
Copy link
Contributor Author

TrejGun commented Jul 4, 2018

screen shot 2018-07-04 at 08 35 34

@danjm

@danjm danjm merged commit 3c75be0 into MetaMask:develop Jul 5, 2018
@danjm
Copy link
Contributor

danjm commented Jul 5, 2018

Thanks @TrejGun

Regarding my request for the screenshot: As a general rule, if we are making any PRs that change the UI in any way, we try to take screenshots or screen captures to show the changes. Just something to keep in mind for any future PRs you might make that affect visual UI changes.

@TrejGun
Copy link
Contributor Author

TrejGun commented Jul 6, 2018

got it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danjm danjm danjm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

text formatting in sign dialog old vs new UI
2 participants
@TrejGun @danjm