Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom RPC makes account switcher unavailable #6094

Closed
codyborn opened this issue Feb 1, 2019 · 5 comments
Closed

Custom RPC makes account switcher unavailable #6094

codyborn opened this issue Feb 1, 2019 · 5 comments
Assignees
Labels
area-customNetworks area-UI Relating to the user interface. type-bug

Comments

@codyborn
Copy link

codyborn commented Feb 1, 2019

Describe the bug
Adding custom RPC results in account switcher (identicon) missing.

To Reproduce
Steps to reproduce the behavior:

  1. Add custom RPC (example: http://ethls6zh7-dns-reg1.westus.cloudapp.azure.com:8540)

Screenshots
image

Browser details (please complete the following information):

  • OS: Windows
  • Browser: Chrome
  • MetaMask Version: 5.3.4
@bdresser bdresser added type-bug area-UI Relating to the user interface. labels Feb 1, 2019
@bdresser
Copy link
Contributor

bdresser commented Feb 4, 2019

@cjeria @chikeichan cool to just set a max-width on the network display and show a ... on the right side?

@cjeria
Copy link
Contributor

cjeria commented Feb 4, 2019

Yep! Ellipsis the network name. Let's also make sure the account image doesn't get pushed out of view as well!

@whymarrh whymarrh self-assigned this Feb 8, 2019
@cjeria
Copy link
Contributor

cjeria commented Feb 12, 2019

Updating my last comment, since I noticed the "nickname" feature already exists, but probably not being used much.

Should we pull out the "nickname" field from behind the "show advanced options" to encourage usage?

@cjeria cjeria closed this as completed Feb 12, 2019
@cjeria cjeria reopened this Feb 12, 2019
@bdresser
Copy link
Contributor

bdresser commented Feb 12, 2019

@cjeria i think we will solve that last point in #5790, especially if we make Network Options its own sub-menu so we can expand all the form fields

@bdresser
Copy link
Contributor

closed via #6494

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-customNetworks area-UI Relating to the user interface. type-bug
Projects
None yet
Development

No branches or pull requests

6 participants