Warn when sending a token to its own address

[danfinlay]

For example

This is a common way to lose funds. I honestly thought we already prevented this, but it seems not.

Acceptance criteria:

• When sending a token to its own address, warn the user "The recipient of this transaction is the token address, this is probably not who you mean to send to." (other copy nominees accepted)

Maybe even:

• Require a user check an extra box that is labeled I am sure I want to probably lose these tokens before the Confirm button is enabled.

[jacobc-eth]

@cjeria I heard you may already have some designs on this?

[cjeria]

I didn't find this specific warning message but I did mock up an additional error message for this use case. Here's the Figma file where these can be found. cc @rachelcope

[jacobc-eth]

Christian's update designs are here: https://www.figma.com/file/KNLr0RnAk5p4duCywOqIhR/Send-Flow-QR-Compatibility?node-id=0%3A1

[jacobc-eth]

Related: #9673

[epheph]

Is there any way to bump the priority of this issue? I don't have definitive proof, but I believe that metamask is the wallet used in many of the losses found on the TokenOops twitter bot, and those losses are commonly over $10,000/day

[rachelcope]

Designs ready. View designs in Figma

This error message is should follow the patterns set out in the error/notification system

[rachelcope]

If this is error is implemented before the new transaction confirmation, then the banner should be shown at the top of the current transaction confirmation design.

[epheph]

Amazing, awesome!

[epheph]

Any idea what happened to this feature? Metamask does not warn any more and users are losing significant funds again.

https://etherscan.io/tx/0x4ac70627fa303cf8dd6bb26b5dc63eab653bac88736c642394a952489cac7231