Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display boolean values when signing typed data #10048

Merged
merged 3 commits into from
Dec 11, 2020
Merged

Display boolean values when signing typed data #10048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b128fe2
Display boolean values when signing typed data
Dec 10, 2020
8c95338
add CHANGELOG entry
Dec 10, 2020
f74d5ed
deal with 'null' and 'undefined'
Dec 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Current Develop Branch
- [#10048](https://github.com/MetaMask/metamask-extension/pull/10048): Display boolean values when signing typed data

## 8.1.8 Wed Dec 09 2020
- [#9992](https://github.com/MetaMask/metamask-extension/pull/9992): Improve transaction params validation
Expand Down
2 changes: 1 addition & 1 deletion ...ts/app/signature-request/signature-request-message/signature-request-message.component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export default class SignatureRequestMessage extends PureComponent {
this.renderNode(value)
) : (
<span className="signature-request-message--node-value">
{value}
{`${value}`}
</span>
)}
</div>
Expand Down