-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to new CurrencyRateController #11005
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
update-currency-rate-controller
branch
3 times, most recently
from
May 7, 2021 14:28
3aa7d1e
to
43420f4
Compare
Builds ready [43420f4]
Page Load Metrics (621 ± 54 ms)
|
Gudahtt
force-pushed
the
update-currency-rate-controller
branch
2 times, most recently
from
May 7, 2021 19:06
01dc7cb
to
f2762f9
Compare
Depends upon #11009, and upon a new major release of |
Builds ready [f2762f9]
Page Load Metrics (643 ± 41 ms)
|
Merged
Gudahtt
force-pushed
the
update-currency-rate-controller
branch
from
May 18, 2021 21:03
f2762f9
to
8431f3f
Compare
Builds ready [8431f3f]
Page Load Metrics (527 ± 45 ms)
|
Gudahtt
force-pushed
the
update-currency-rate-controller
branch
from
May 19, 2021 17:07
8431f3f
to
3379752
Compare
Builds ready [3379752]
Page Load Metrics (618 ± 37 ms)
|
Builds ready [3379752]
Page Load Metrics (621 ± 40 ms)
|
The CurrencyRateController has been migrated to the BaseControllerV2 API, which includes various API changes. These changes include: * The constructor now expects to be passed a `RestrictedControllerMessenger`. * State changes are subscribed to via the `ControllerMessenger` now, rather than via a `subscribe` function. * The state and configration are passed in as one "options" object, rather than as two separate parameters * The polling needs to be started explicitly by calling `start`. It can be stopped and started on-demand now as well. * Changing the current currency or native currency will now throw an error if we fail to update the conversion rate. The `ComposableObservableStore` has been updated to accomodate these new types of controllers. The constructor has been updated to use an options bag pattern as well, to make the addition of the new required `controllerMessenger` parameter a bit less unweildly.
Gudahtt
force-pushed
the
update-currency-rate-controller
branch
from
May 19, 2021 19:33
3379752
to
02e06c4
Compare
Builds ready [02e06c4]
Page Load Metrics (639 ± 45 ms)
|
shanejonas
approved these changes
May 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CurrencyRateController has been migrated to the BaseControllerV2 API, which includes various API changes. These changes include:
RestrictedControllerMessenger
.ControllerMessenger
now, rather than via asubscribe
function.start
. It can be stopped and started on-demand now as well.Manual testing instructions: