Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump allow scripts #11134

Merged
merged 1 commit into from
May 20, 2021
Merged

bump allow scripts #11134

merged 1 commit into from
May 20, 2021

Conversation

@EtDu EtDu requested a review from a team as a code owner May 19, 2021 06:59
@EtDu EtDu requested a review from NiranjanaBinoy May 19, 2021 06:59
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [10888b8]
Page Load Metrics (691 ± 52 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint549769115
domContentLoaded47085068910952
load47285169110952
domInteractive47085068910952

@Gudahtt
Copy link
Member

Gudahtt commented May 19, 2021

So the only change is that there is now a trailing newline - is that correct?

@kumavis
Copy link
Member

kumavis commented May 20, 2021

@Gudahtt correct - it now appends a newline when generating the policy https://npmfs.com/compare/@lavamoat/allow-scripts/1.0.5/1.0.6/

@EtDu
Copy link
Contributor Author

EtDu commented May 20, 2021

For the sake of our linter. Maybe we broke someone else's... 🤷

@Gudahtt
Copy link
Member

Gudahtt commented May 20, 2021

Doubtful. It's a requirement of the POSIX standard, for one thing. The npm CLI will always include a trailing newline in newly generated package.json files as well, and they typically dictate the format used by any tooling.

Though this might still be broken on Windows, for any projects that are setup to use \r\n. Ideally allow-scripts would preserve the pre-existing formatting.

@Gudahtt Gudahtt merged commit d381f70 into develop May 20, 2021
@Gudahtt Gudahtt deleted the allow-scripts-bump branch May 20, 2021 02:56
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants