Fixing jest component test output errors

[ryanml]

There were quite a few non-fatal errors in our jest component tests related to missing required properties. Examples:

 console.error
      Warning: Failed prop type: The prop `customPriceIsExcessive` is marked as required in `GasModalPageContainer`, but its value is `undefined`.
          in GasModalPageContainer

      65 |   beforeEach(() => {
      66 |     wrapper = shallowWithContext(
    > 67 |       <GasModalPageContainer
         |       ^
      68 |         cancelAndClose={propsMethodSpies.cancelAndClose}
      69 |         onSubmit={propsMethodSpies.onSubmit}
      70 |         fetchBasicGasEstimates={propsMethodSpies.fetchBasicGasEstimates}

    console.error
      Warning: useLayoutEffect does nothing on the server, because its effect cannot be encoded into the server renderer's output format. This will lead to a mismatch between the initial, non-hydrated UI and the intended UI. To avoid this, useLayoutEffect should only be used in components that render exclusively on the client. See https://fb.me/react-uselayouteffect-ssr for common fixes.
          in NetworkDisplay
          in div
          in div
          in ConfirmPageContainerHeader
          in Context.Provider

The following error was fixed for the MenuBar test:

    console.error
      Warning: An update to Menu inside a test was not wrapped in act(...).
      
      When testing, code that causes React state updates should be wrapped into act(...):
      
      act(() => {
        /* fire events that update state */
      });
      /* assert on the output */
      
      This ensures that you're testing the behavior the user would see in the browser. Learn more at https://fb.me/react-wrap-tests-with-act
          in Menu (created by AccountOptionsMenu)
          in AccountOptionsMenu (created by MenuBar)
          in div (created by MenuBar)
          in MenuBar
          in Provider
          in Router (created by MemoryRouter)
          in MemoryRouter (created by Wrapper)
          in Wrapper (created by WrapperComponent)
          in WrapperComponent

The tests for IntroPopup, an unused component which has been removed in this change, was causing:

    console.error
      Warning: Failed prop type: The prop `title` is marked as required in `PopoverPortal`, but its value is `null`.
          in PopoverPortal (created by IntroPopup)
          in IntroPopup
          in LegacyI18nProvider (created by WithoutStore)
          in I18nProvider (created by WithoutStore)
          in Router (created by MemoryRouter)
          in MemoryRouter (created by WithoutStore)
          in WithoutStore (created by Wrapper)
          in Provider (created by Wrapper)
          in Wrapper

      40 |   return (
      41 |     <div className="intro-popup">
    > 42 |       <Popover
         |       ^
      43 |         className="intro-popup__popover"
      44 |         title={t('swapIntroPopupTitle')}
      45 |         subtitle={t('swapIntroPopupSubTitle')}

[metamaskbot]

Builds ready [ccba2c9]

• builds: chrome, firefox, opera
• bundle viz: background, ui, inpage, contentscript, ui-libs, bg-libs, phishing-detect
• build viz: Build System
• code coverage: Report
• storybook: Storybook
• all artifacts

Page Load Metrics (634 ± 89 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	45	84	62	13	6
		domContentLoaded	380	1233	632	184	89
		load	382	1234	634	185	89
		domInteractive	380	1232	632	184	88