Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bringing recovery phrase text notification to the top #11259

Merged
merged 1 commit into from Jun 9, 2021
Merged

Bringing recovery phrase text notification to the top #11259

merged 1 commit into from Jun 9, 2021

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Jun 9, 2021

Screen Shot 2021-06-09 at 3 56 27 AM

@ryanml ryanml self-assigned this Jun 9, 2021
@ryanml ryanml requested a review from a team as a code owner June 9, 2021 11:00
@ryanml ryanml requested a review from adonesky1 June 9, 2021 11:00
ryanml
ryanml commented Jun 9, 2021
View reviewed changes
shared/notifications/index.js
@@ -24,7 +24,7 @@ export const UI_NOTIFICATIONS = {
},
5: {
id: 5,
date: '2021-05-18',
date: '2021-06-09',
Copy link
Contributor Author

@ryanml ryanml Jun 9, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since notification order is determined by date in the getSortedNotificationsToShow selector, it made sense to just to update the date of the Recovery phrase entry rather than re-order any other static structures

@ryanml ryanml requested a review from danjm June 9, 2021 11:01
@metamaskbot
Copy link
Collaborator

Builds ready [c04a7bb]
Page Load Metrics (649 ± 9 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint46856294
domContentLoaded609692648189
load611693649189
domInteractive609691647189

@ryanml
Copy link
Contributor Author

ryanml commented Jun 9, 2021

Merging as the audit failure is unrelated to this change

@ryanml ryanml merged commit d7c8186 into develop Jun 9, 2021
@ryanml ryanml deleted the raise-phrase-notification branch June 9, 2021 11:33
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danjm danjm danjm approved these changes

@adonesky1 adonesky1 Awaiting requested review from adonesky1

Assignees

@ryanml ryanml

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ryanml @metamaskbot @danjm