Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making bundle viz links collapsable #11542

Merged
merged 1 commit into from Jul 16, 2021
Merged

Making bundle viz links collapsable #11542

merged 1 commit into from Jul 16, 2021

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Jul 16, 2021 •
edited

Also contains some code cleanup of bundle name parsing

@ryanml ryanml self-assigned this Jul 16, 2021
@ryanml ryanml requested review from kumavis and a team as code owners July 16, 2021 05:07
@ryanml ryanml requested a review from brad-decker July 16, 2021 05:07
@ryanml ryanml force-pushed the metamaskbot-viz-link-improvements branch from da3c756 to 7cafbdf Compare July 16, 2021 05:28
ryanml
ryanml commented Jul 16, 2021
View reviewed changes
development/metamaskbot-build-announce.js Outdated
@@ -92,7 +85,10 @@ async function start() {

const contentRows = [
`builds: ${buildLinks}`,
`bundle viz: ${bundleMarkup}`,
`<details>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have liked to clean up the spacing some by applying margin-bottom: 0 here, but looks like GH strips attributes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the bundle viz links to the last row and this solves the aforementioned issue

@MetaMask MetaMask deleted a comment from metamaskbot Jul 16, 2021
@ryanml ryanml force-pushed the metamaskbot-viz-link-improvements branch from 7cafbdf to fd4d0bc Compare July 16, 2021 05:31
@metamaskbot
Copy link
Collaborator

Builds ready [fd4d0bc]
Page Load Metrics (658 ± 26 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint55826684
domContentLoaded5487616575426
load5487626585426
domInteractive5477616565426

rekmarks
rekmarks approved these changes Jul 16, 2021
View reviewed changes
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice regex 😎

NiranjanaBinoy
NiranjanaBinoy approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@NiranjanaBinoy NiranjanaBinoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanml ryanml merged commit ff521fe into develop Jul 16, 2021
@ryanml ryanml deleted the metamaskbot-viz-link-improvements branch July 16, 2021 18:23
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rekmarks rekmarks rekmarks approved these changes

@NiranjanaBinoy NiranjanaBinoy NiranjanaBinoy approved these changes

@kumavis kumavis Awaiting requested review from kumavis kumavis is a code owner

@brad-decker brad-decker Awaiting requested review from brad-decker

Assignees

@ryanml ryanml

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ryanml @metamaskbot @rekmarks @NiranjanaBinoy