Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restoring mobile sync warning text #12284

Merged
merged 1 commit into from Oct 6, 2021
Merged

Restoring mobile sync warning text #12284

merged 1 commit into from Oct 6, 2021

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Oct 5, 2021

This was accidentally overwritten by: 769beb2#diff-7509d7529ea1cbc57ef79713676f7d124d9d5a446053f94836876c4cd3f3ccd6R1338

Originally implemented in: #11935

Screen Shot 2021-10-05 at 1 40 12 PM

@ryanml ryanml self-assigned this Oct 5, 2021
@ryanml ryanml requested a review from a team as a code owner October 5, 2021 20:45
adonesky1
adonesky1 approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metamaskbot
Copy link
Collaborator

Builds ready [b69adc3]
Page Load Metrics (297 ± 32 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint2515602896531
domContentLoaded2405482786531
load2615772976732
domInteractive2405482786531

highlights:

storybook

@ryanml ryanml merged commit cd09e5b into develop Oct 6, 2021
@ryanml ryanml deleted the fix-sync-warning branch October 6, 2021 12:02
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danjm danjm danjm approved these changes

@adonesky1 adonesky1 adonesky1 approved these changes

@danfinlay danfinlay Awaiting requested review from danfinlay

@NiranjanaBinoy NiranjanaBinoy Awaiting requested review from NiranjanaBinoy

Assignees

@ryanml ryanml

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ryanml @metamaskbot @danjm @adonesky1