Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do case-insensitive comparisons of token addresses in view-quote and build-quote #12315

Merged
merged 1 commit into from Oct 8, 2021

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Oct 8, 2021

Fixes #12306

We recently change the way that token addresses are saved in state, so that they are now checksummed. This breaks attempts to compare token addresses in state with token addresses from the swaps apis. This PR corrects those comparisons.

@danjm danjm requested a review from a team as a code owner October 8, 2021 20:35
@danjm danjm requested a review from jpuri October 8, 2021 20:35
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@metamaskbot
Copy link
Collaborator

Builds ready [f0ad64e]
Page Load Metrics (387 ± 55 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7369334911857
domContentLoaded27369436811857
load29070438711555
domInteractive27369436811857

Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danjm danjm merged commit 18ca9d1 into develop Oct 8, 2021
@danjm danjm deleted the fix-swaps-token-address-comparisons branch October 8, 2021 21:27
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to retrieve BUSD balance on Binance Smart Chain while swapping on metamask
4 participants