Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix width and padding of the hide token modal in popup view #12381

Merged
merged 1 commit into from Oct 18, 2021
Merged

Fix width and padding of the hide token modal in popup view #12381

merged 1 commit into from Oct 18, 2021

Conversation

filipsekulic
Copy link
Contributor

@filipsekulic filipsekulic commented Oct 18, 2021 •
edited by darkwing

Fixes: #12344

Fix width and padding of the hide token modal in popup view.

Screenshot from 2021-10-18 10-21-13

@filipsekulic filipsekulic requested a review from a team as a code owner October 18, 2021 09:05
@filipsekulic
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@filipsekulic filipsekulic force-pushed the fix/fix-width-and-padding-of-the-hide-token--modal-in-popup-view branch from a0eba2d to 260194c Compare October 18, 2021 09:11
@ghost
Copy link

ghost commented Oct 18, 2021

Verified by QA

@filipsekulic filipsekulic self-assigned this Oct 18, 2021
@david0xd david0xd self-requested a review October 18, 2021 13:00
david0xd
david0xd approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@david0xd david0xd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@filipsekulic filipsekulic changed the title WIP: Fix width and padding of the hide token modal in popup view Fix width and padding of the hide token modal in popup view Oct 18, 2021
adonesky1
adonesky1 approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danjm danjm merged commit cca852d into MetaMask:develop Oct 18, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danjm danjm danjm approved these changes

@david0xd david0xd david0xd approved these changes

@adonesky1 adonesky1 adonesky1 approved these changes

@PeterYinusa PeterYinusa Awaiting requested review from PeterYinusa PeterYinusa is a code owner automatically assigned from MetaMask/extension-devs

Assignees

@filipsekulic filipsekulic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix width and padding of the "Hide Token" modal in popup view
4 participants
@filipsekulic @danjm @david0xd @adonesky1