Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync master with develop #12772

Merged
merged 8 commits into from
Nov 22, 2021
Merged

Sync master with develop #12772

merged 8 commits into from
Nov 22, 2021

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Nov 20, 2021

This brings develop up-to-date with v10.6.1

kumavis and others added 7 commits November 19, 2021 10:53
…2573)

* metametrics - ensure segment submission failures do not bubble up

* metametrics - differentiate between trackEvent and submitEvent

* metametrics - validate event in trackEvent

* metametrics - re-throw error on clean stack

* lint fix

* controllers/metametrics - take a captureException option

* controllers/metametrics - capture and report any errors in trackPage

* Update app/scripts/controllers/metametrics.js

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
`improved-yarn-audit` has been updated so that it supports GitHub
advisories. Two new GitHub advisories have been ignored, as they are
both moderate RegExp DoS vulnerabilities that don't affect us, and they
are embedded deep within our dependency graph and are difficult to
update.
@ryanml ryanml requested review from danjm and a team November 20, 2021 00:09
@ryanml ryanml self-assigned this Nov 20, 2021
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [d4aa63f]
Page Load Metrics (775 ± 19 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint296830540230111
domContentLoaded7068407743919
load7068427753919
domInteractive7068407743919

tmashuang
tmashuang previously approved these changes Nov 21, 2021
@metamaskbot
Copy link
Collaborator

Builds ready [74719a8]
Page Load Metrics (747 ± 20 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint275769523216104
domContentLoaded6698727464220
load6708727474220
domInteractive6698727464220

@ryanml ryanml merged commit 0431821 into develop Nov 22, 2021
@ryanml ryanml deleted the master-sync branch November 22, 2021 16:43
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants