Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear the clipboard after seed phrase is pasted (Restore vault) #12987

Merged
merged 1 commit into from Dec 6, 2021
Merged

Clear the clipboard after seed phrase is pasted (Restore vault) #12987

merged 1 commit into from Dec 6, 2021

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Dec 6, 2021

Follow up to: #12828

Testing steps:

  1. Lock wallet
  2. Click import using secret recovery phrase
  3. Paste seed phrase in input

Expected:
Clipboard is cleared, similar to onboarding/first time flow

@ryanml ryanml requested a review from Gudahtt December 6, 2021 18:31
@ryanml ryanml self-assigned this Dec 6, 2021
@ryanml ryanml requested a review from a team as a code owner December 6, 2021 18:31
Gudahtt
Gudahtt approved these changes Dec 6, 2021
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ryanml ryanml requested a review from a team December 6, 2021 18:34
mcmire
mcmire approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, LGTM as well.

@metamaskbot
Copy link
Collaborator

Builds ready [75ed412]
Page Load Metrics (1001 ± 23 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint661072412435209
domContentLoaded942111310014723
load942112110014823
domInteractive942111310014723

@ryanml ryanml merged commit bab48c8 into develop Dec 6, 2021
@ryanml ryanml deleted the clear-seed-phrase-restore-vault branch December 6, 2021 19:17
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcmire mcmire mcmire approved these changes

@jpuri jpuri jpuri approved these changes

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees

@ryanml ryanml

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ryanml @metamaskbot @mcmire @jpuri @Gudahtt