Allow wallet_addEthereumChain for ethereum chains #13405
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
I have read the CLA Document and I hereby sign the CLA |
| }), | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
I am not sure, id there any reason this check was put in place initially ?
There was a problem hiding this comment.
I could not find any documentation or information in commit history as to why that check is there. The same functionality is permitted through manual adding of RPC networks. In both flows, warnings are presented with regards to existing chain id networks.
There was a problem hiding this comment.
Hi @jpuri, any update on this?
|
Hi @ryanml @jpuri , just wanted to bump this PR. There's been an increasing interest for allowing custom RPC endpoints for eth networks - https://twitter.com/MetaMask/status/1499448226180583429 |
|
What is the status of this? |
|
@adonesky1 can we possibly fix this PR up, merge it and then rebase your work in #16733 so that we incorporate this community contribution. |
|
@kurushdubash -- @adonesky1 cherry picked your commit into his branch so that you will get credit for your contribution. 🎉 please head over to #16733 for any futher comments on this thread. |
|
@kurushdubash your commit landed as part of #16733 and you now have a shiny "contributor" label on your interactions with the repo:
Thanks @adonesky1 for taking the time to carry out my request to carry this commit into the codebase. |
Fixes: #13629
Explanation: Metamask allows adding a custom RPC with any of the default chain ids. However, it blocks requests for
wallet_addEthereumChainwhen thechain_idis one of the defaults that come with Metamask. Removing this block would allowwallet_addEthereumChainrequests for Ethereum networks. This is a more convenient experience for users versus having to manually add a custom RPC and matches the functionality of manually adding an Ethereum chain.Manual testing steps:
yarn testsand verified all tests passyarn build:testand verified all tests passwallet_addEthereumChainrequest with an Ethereumchain_idand verified it was successful with no errors