[Bug]: Balance does not update on duplicate chainId network #13690 #14245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [fd59007]Page Load Metrics (1293 ± 34 ms)
|
|
Verified by QA |
brad-decker
previously approved these changes
Aug 25, 2022
|
@dragana Could you rebase this please and fix conflicts? we'll get it landed after that |
Ellajoke
previously approved these changes
Aug 25, 2022
dragana8
dismissed stale reviews from Ellajoke, brad-decker, ghost
, and segun
via
bbee415
dragana8
force-pushed
the
balance-duplicate-chainId
branch
from
fd59007
to
bbee415
Compare
Builds ready [bbee415]
Page Load Metrics (1633 ± 39 ms)
|
|
@brad-decker done |
dragana8
force-pushed
the
balance-duplicate-chainId
branch
from
bbee415
to
276ec39
Compare
Builds ready [276ec39]
Page Load Metrics (1904 ± 64 ms)
|
brad-decker
previously approved these changes
Sep 5, 2022
NiranjanaBinoy
previously approved these changes
Nov 4, 2022
brad-decker
dismissed stale reviews from NiranjanaBinoy and themself
via
0884411
brad-decker
force-pushed
the
balance-duplicate-chainId
branch
from
276ec39
to
0884411
Compare
brad-decker
approved these changes
Nov 4, 2022
There was a problem hiding this comment.
I rebased the pr for @dragana8, please reapprove when ready!
NiranjanaBinoy
approved these changes
Nov 4, 2022
Builds ready [0884411]
Page Load Metrics (2660 ± 164 ms)
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Currently, the balance of an account won't update if the network selected has a chainId that is already present in Metamask. That happens because in account-tracker.js there is a check for chainId and if it belonged to known networks ( as in this case it was Ropsten network) it called the method that checked balance on Ropsten network and not localhost as it should.
In order to solve this problem, I added if statement that checks if rpcUrl is localhost and in that case the right method (updateBalance) is being called.
More information
Screenshots/Screencaps
Before
After