Opening Network Forms in full screen from the popup view #15442
Conversation
Builds ready [a768797]
Page Load Metrics (1744 ± 81 ms)
highlights: |
| @@ -68,7 +66,7 @@ const NetworksListItem = ({ | |||
| setSearchedNetworks([]); | |||
| dispatch(setSelectedSettingsRpcUrl(rpcUrl)); | |||
| if (!isFullScreen) { | |||
| history.push(NETWORKS_FORM_ROUTE); | |||
| global.platform.openExtensionInBrowser(NETWORKS_ROUTE); | |||
There was a problem hiding this comment.
Why NETWORKS_ROUTE instead of NETWORKS_FORM_ROUTE?
There was a problem hiding this comment.
const NETWORKS_ROUTE = '/settings/networks';
const NETWORKS_FORM_ROUTE = '/settings/networks/form';
Went down a bit of a rabbit hole here. As the issue shows, the route, settings/networks/form, resolves to the generic settings page. From my investigation, it appears the path is not resolving to the networks tab properly and from there, the shouldRenderNetworkForm value when the route is NETWORKS_FORM_ROUTE is not being set.
hardcoding the route to resolve to the networks tab and setting shouldRenderNetworkForm to true shows this popup page:
I think that applying the current changes now would make NETWORKS_FORM_ROUTE obsolete which might not be what we want.
p.s. i deleted the last copy of this comment and reposted this comment with the proper reference to see if I can remove the reference to the incorrect issue ticket
There was a problem hiding this comment.
p.s.p.s. the reference to this PR from the unrelated issue was not removed when I deleted the comment I mentioned above
Fixes: #15399
This restores the behavior of opening the Network form in full view when attempting to edit one via the popup window.
Testing involves a simple regression check in the full screen view and ensuring the aformentioned behavior in the popup