Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLASK] snaps-skunkworks@0.20.0 #15706

Merged
merged 10 commits into from Aug 26, 2022
Merged

[FLASK] snaps-skunkworks@0.20.0 #15706

merged 10 commits into from Aug 26, 2022

Conversation

FrederikBolding
Copy link
Member

Explanation

Bumps snaps-skunkworks packages to 0.20.0 and handles breaking changes.

@metamaskbot
Copy link
Collaborator

Builds ready [d3beb6e]
Page Load Metrics (1848 ± 77 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint99176132199
domContentLoaded15872063182414067
load15872188184816177
domInteractive15872062182414067

@FrederikBolding FrederikBolding dismissed a stale review via aba16b4 August 26, 2022 08:19
@FrederikBolding FrederikBolding marked this pull request as ready for review August 26, 2022 08:41
@FrederikBolding FrederikBolding requested a review from a team as a code owner August 26, 2022 08:41
@metamaskbot
Copy link
Collaborator

Builds ready [1c9c5f8]
Page Load Metrics (2163 ± 135 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1002097250426204
domContentLoaded165925822139279134
load171326212163282135
domInteractive165925822139279134

highlights:

storybook

hmalik88
hmalik88 approved these changes Aug 26, 2022
View reviewed changes
Copy link
Contributor

@hmalik88 hmalik88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FrederikBolding FrederikBolding merged commit 7fc418a into develop Aug 26, 2022
@FrederikBolding FrederikBolding deleted the snaps-skunkworks@0.20.0 branch August 26, 2022 11:48
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Mrtenz Mrtenz Mrtenz approved these changes

@hmalik88 hmalik88 hmalik88 approved these changes

@PeterYinusa PeterYinusa Awaiting requested review from PeterYinusa PeterYinusa is a code owner automatically assigned from MetaMask/extension-devs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@FrederikBolding @metamaskbot @Mrtenz @hmalik88