[FLASK] Fix an issue with installing and updating snaps with 0 permissions #15796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds ready [8a6c49e]
Page Load Metrics (2360 ± 99 ms)
highlights:storybook
|
FrederikBolding
changed the title
Builds ready [783a654]
Page Load Metrics (1281 ± 43 ms)
highlights:storybook
|
ritave
approved these changes
Sep 20, 2022
| @@ -0,0 +1,62 @@ | |||
| diff --git a/node_modules/@metamask/snap-controllers/dist/snaps/SnapController.js b/node_modules/@metamask/snap-controllers/dist/snaps/SnapController.js | |||
There was a problem hiding this comment.
Can you explain why we're using a patch instead of latest snap-controllers version?
There was a problem hiding this comment.
Its this fix applied: MetaMask/snaps#754
Will remove once we cut another release of skunkworks.
| const revokedPermissions = request.unusedPermissions ?? {}; | ||
| const newPermissions = request.newPermissions ?? {}; | ||
| const hasPermissions = | ||
| Object.keys(approvedPermissions).length + |
There was a problem hiding this comment.
please add parentheses around arithmetic to avoid ambiguity.
(yes I know that + has higher precedence over >, but it makes the intentions clearer)
(
Object.keys(approvedPermissions).length +
Object.keys(revokedPermissions).length +
Object.keys(newPermissions).length
) > 0;There was a problem hiding this comment.
Not possible due to linting
| rejectSnapInstall={(requestId) => { | ||
| rejectPendingApproval( | ||
| requestId, | ||
| serializeError(ethErrors.provider.userRejectedRequest()), |
There was a problem hiding this comment.
I feel iffy that we're serialising errors in the UI and using rpc errors in general.
| export function getFirstSnapUpdateRequest(state) { | ||
| const requests = getSnapUpdateRequests(state); | ||
| export function getFirstSnapInstallOrUpdateRequest(state) { | ||
| const requests = getSnapInstallOrUpdateRequests(state); |
There was a problem hiding this comment.
return getSnapInstallOrUpdateRequests(state)?.[0] ?? null
|
@ritave Will improve this in the upcoming skunkworks PR. Merging this as is. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes an issue with installing snaps that didn't request any permissions.
Manual Testing Steps