Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kevlar #16384

Closed
wants to merge 11 commits into from
Closed

Kevlar #16384

wants to merge 11 commits into from

Conversation

kumavis
Copy link
Member

@kumavis kumavis commented Nov 4, 2022

update kevlar experiment

@kumavis kumavis requested a review from a team as a code owner November 4, 2022 18:34
@kumavis kumavis requested review from digiwand and removed request for a team November 4, 2022 18:34
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

CLA Signature Action:

Thank you for your submission, we really appreciate it. We ask that you read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:

I have read the CLA Document and I hereby sign the CLA

By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository.

0 out of 1 committers have signed the CLA.
@shresthagrawal

@kumavis
Copy link
Member Author

kumavis commented Nov 4, 2022

@digiwand review from you was automatically requested - this is not targeting develop at this time so you dont need to review it

@kumavis
Copy link
Member Author

kumavis commented Nov 9, 2022

esm/cjs issue in unit test

Error [ERR_REQUIRE_ESM]: require() of ES Module /home/circleci/project/node_modules/@lightclients/kevlar/dist/index.js from /home/circleci/project/app/scripts/controllers/network/createJsonRpcClient.js not supported.
Instead change the require of index.js in /home/circleci/project/app/scripts/controllers/network/createJsonRpcClient.js to a dynamic import() which is available in all CommonJS modules

@shresthagrawal
Copy link

@kumavis any ideas on how this can be fixed?

@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Jul 20, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions.

@github-actions github-actions bot closed this Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale issues and PRs marked as stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants