Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update UI for transaction security check in settings #16830

Merged
merged 10 commits into from Jan 4, 2023
Merged

Update UI for transaction security check in settings #16830

merged 10 commits into from Jan 4, 2023

Conversation

filipsekulic
Copy link
Contributor

@filipsekulic filipsekulic commented Dec 7, 2022 •
edited

Explanation

Screenshots/Screencaps

Before

Before - modal view

Before - fullscreen view

After

After - modal view

After - fullscreen view

Manual Testing Steps

  1. Copy TRANSACTION_SECURITY_PROVIDER=1 into .metamaskrc file
  2. Start the app
  3. Go to Settings -> Experimental tab and check the new design

@filipsekulic filipsekulic self-assigned this Dec 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@filipsekulic filipsekulic force-pushed the update-ui-for-transaction-security-check-in-settings branch from fccb283 to 5c53bdc Compare December 7, 2022 11:02
@metamaskbot
Copy link
Collaborator

Builds ready [5c53bdc]
Page Load Metrics (2132 ± 76 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1013051334622
domContentLoaded17502438211816077
load17582438213215876
domInteractive17502438211816077
Bundle size diffs
  • background: 0 bytes
  • ui: 905 bytes
  • common: 0 bytes

highlights:

storybook

@filipsekulic filipsekulic force-pushed the update-ui-for-transaction-security-check-in-settings branch from e1c4cba to 6164a7a Compare December 23, 2022 12:43
@filipsekulic filipsekulic changed the title [WIP] Update UI for transaction security check in settings Update UI for transaction security check in settings Dec 26, 2022
@metamaskbot
Copy link
Collaborator

Builds ready [959ea83]
Page Load Metrics (1570 ± 168 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint991871242412
domContentLoaded116622261547344165
load116622271570350168
domInteractive116622261547344165
Bundle size diffs
  • background: 0 bytes
  • ui: 1166 bytes
  • common: 0 bytes

highlights:

storybook

@metamaskbot
Copy link
Collaborator

Builds ready [d6713a0]
Page Load Metrics (1634 ± 199 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint931430206283136
domContentLoaded115929881622416200
load117329881634414199
domInteractive115929871622416200
Bundle size diffs
  • background: 0 bytes
  • ui: 1166 bytes
  • common: 0 bytes

highlights:

storybook

@mirjanaKukic
Copy link
Contributor

Verified by QA

@filipsekulic filipsekulic marked this pull request as ready for review December 27, 2022 13:47
@filipsekulic filipsekulic requested a review from a team as a code owner December 27, 2022 13:47
@brad-decker brad-decker merged commit e6038d5 into develop Jan 4, 2023
@brad-decker brad-decker deleted the update-ui-for-transaction-security-check-in-settings branch January 4, 2023 21:59
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpuri jpuri jpuri approved these changes

@brad-decker brad-decker brad-decker approved these changes

@georgewrmarshall georgewrmarshall Awaiting requested review from georgewrmarshall georgewrmarshall is a code owner automatically assigned from MetaMask/extension-devs

Assignees

@filipsekulic filipsekulic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wallet Tx Security Provider: Update UI for Transaction Security Check in Settings
5 participants
@filipsekulic @metamaskbot @mirjanaKukic @jpuri @brad-decker