Sanitising string on signature request pages #17571

jpuri · 2023-02-02T15:21:03Z

Sanitising string on signature request pages

Ref: https://app.zenhub.com/workspaces/confirmations-6245e6e2348677001213b8d2/issues/gh/metamask/metamask-planning/306

github-actions · 2023-02-02T15:21:15Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2023-02-02T19:02:01Z

Builds ready [690d56e]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1174 ± 85 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	98	159	120	15	7
		domContentLoaded	975	1518	1146	180	86
		load	979	1544	1174	176	85
		domInteractive	975	1518	1146	180	86

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 bytes
ui: 229 bytes
common: 204 bytes

ui/helpers/utils/util.js

ui/components/app/signature-request/signature-request-data/signature-request-data.js

Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>

…nature-request-data.js Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>

metamaskbot · 2023-02-03T23:43:31Z

Builds ready [8feffbe]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1244 ± 122 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	95	162	121	17	8
		domContentLoaded	946	1673	1216	241	116
		load	946	1796	1244	255	122
		domInteractive	946	1673	1216	241	116

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 bytes
ui: 234 bytes
common: 204 bytes

…ask-extension into improving_message_signing

metamaskbot · 2023-02-06T13:02:39Z

Builds ready [b1bbddd]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1350 ± 145 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	100	194	132	27	13
		domContentLoaded	962	1914	1328	303	145
		load	976	1940	1350	303	145
		domInteractive	962	1914	1328	303	145

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 bytes
ui: 209 bytes
common: 204 bytes

ui/components/app/signature-request-original/signature-request-original.component.js

ui/helpers/utils/util.js

metamaskbot · 2023-02-06T17:11:12Z

Builds ready [473e065]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1194 ± 90 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	100	188	126	19	9
		domContentLoaded	957	1575	1189	186	89
		load	957	1575	1194	187	90
		domInteractive	957	1575	1189	186	89

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 bytes
ui: 209 bytes
common: 204 bytes

metamaskbot · 2023-02-07T07:03:31Z

Builds ready [08e233f]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1284 ± 115 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	90	165	117	21	10
		domContentLoaded	976	1558	1257	234	112
		load	990	1669	1284	239	115
		domInteractive	976	1558	1257	234	112

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 bytes
ui: 209 bytes
common: 206 bytes

ui/helpers/utils/util.js

digiwand

Nice fix!

metamaskbot · 2023-02-08T15:10:23Z

Builds ready [05ccd93]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1292 ± 173 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	95	202	127	24	12
		domContentLoaded	972	2325	1265	333	160
		load	993	2452	1292	361	173
		domInteractive	972	2325	1265	333	160

seaona · 2023-02-16T10:17:52Z

I see it fixed!! Great job @jpuri !!

Sanitizing string on signature request pages

a8d8aec

jpuri requested a review from danjm February 2, 2023 15:21

jpuri requested a review from a team as a code owner February 2, 2023 15:21

jpuri added 2 commits February 3, 2023 00:05

fix build

92c331d

Merge branch 'develop' into improving_message_signing

690d56e

digiwand reviewed Feb 3, 2023

View reviewed changes

ui/helpers/utils/util.js Outdated Show resolved Hide resolved

digiwand reviewed Feb 3, 2023

View reviewed changes

ui/components/app/signature-request/signature-request-data/signature-request-data.js Outdated Show resolved Hide resolved

jpuri and others added 2 commits February 4, 2023 04:49

Update ui/helpers/utils/util.js

dca11ff

Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>

Update ui/components/app/signature-request/signature-request-data/sig…

8feffbe

…nature-request-data.js Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>

jpuri requested a review from digiwand February 3, 2023 23:19

jpuri added 5 commits February 5, 2023 05:11

fix

37b47ff

merge

f72df80

Merge branch 'develop' into improving_message_signing

ab2b1d9

fix build

0a8090a

Merge branch 'improving_message_signing' of github.com:MetaMask/metam…

b1bbddd

…ask-extension into improving_message_signing

digiwand reviewed Feb 6, 2023

View reviewed changes

ui/components/app/signature-request-original/signature-request-original.component.js Outdated Show resolved Hide resolved

improvement

473e065

digiwand reviewed Feb 6, 2023

View reviewed changes

ui/helpers/utils/util.js Outdated Show resolved Hide resolved

jpuri added 2 commits February 7, 2023 11:43

fix

4e9efa6

merge

77a36b9

jpuri requested a review from digiwand February 7, 2023 06:14

jpuri added 2 commits February 7, 2023 12:05

fix build

4a6b75e

fix build

08e233f

digiwand reviewed Feb 7, 2023

View reviewed changes

ui/helpers/utils/util.js Show resolved Hide resolved

digiwand approved these changes Feb 7, 2023

View reviewed changes

Merge branch 'develop' into improving_message_signing

05ccd93

segun approved these changes Feb 8, 2023

View reviewed changes

jpuri merged commit 61a7850 into develop Feb 8, 2023

jpuri deleted the improving_message_signing branch February 8, 2023 23:05

github-actions bot locked and limited conversation to collaborators Feb 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sanitising string on signature request pages #17571

Sanitising string on signature request pages #17571

jpuri commented Feb 2, 2023

github-actions bot commented Feb 2, 2023

metamaskbot commented Feb 2, 2023

metamaskbot commented Feb 3, 2023

metamaskbot commented Feb 6, 2023

metamaskbot commented Feb 6, 2023

metamaskbot commented Feb 7, 2023

digiwand left a comment

metamaskbot commented Feb 8, 2023

seaona commented Feb 16, 2023

Sanitising string on signature request pages #17571

Sanitising string on signature request pages #17571

Conversation

jpuri commented Feb 2, 2023

github-actions bot commented Feb 2, 2023

metamaskbot commented Feb 2, 2023

metamaskbot commented Feb 3, 2023

metamaskbot commented Feb 6, 2023

metamaskbot commented Feb 6, 2023

metamaskbot commented Feb 7, 2023

digiwand left a comment

Choose a reason for hiding this comment

metamaskbot commented Feb 8, 2023

seaona commented Feb 16, 2023