Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MMI] Conditional change title in home if buildType is MMI #17898

Merged

Conversation

albertolive
Copy link
Contributor

@albertolive albertolive commented Feb 24, 2023

Explanation

Conditional change title in home if buildType is MMI

https://consensyssoftware.atlassian.net/browse/MMI-2483

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [2b4b094]
Page Load Metrics (1595 ± 50 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint95146114126
domContentLoaded1453173915667134
load14541839159510350
domInteractive1453173915667134
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@MetaMask MetaMask deleted a comment Feb 27, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [e7a7a11]
Page Load Metrics (1812 ± 77 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1083841566833
domContentLoaded14192173176916579
load15062173181215977
domInteractive14192173176916579
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@albertolive albertolive marked this pull request as ready for review March 1, 2023 14:39
@albertolive albertolive requested review from a team and kumavis as code owners March 1, 2023 14:39
app/home.html Show resolved Hide resolved
@metamaskbot
Copy link
Collaborator

Builds ready [29aaa67]
Page Load Metrics (1819 ± 77 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint109170135168
domContentLoaded14842147178716278
load15112147181916077
domInteractive14842147178716278
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@brad-decker brad-decker merged commit cd26ad0 into develop Mar 2, 2023
@brad-decker brad-decker deleted the feature/MMI-2483-MMI-buildType-change-extension-title branch March 2, 2023 16:18
@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2023
@michaelmccallam michaelmccallam added Sev3-low Low severity; minimal to no impact upon users and removed Sev3-low Low severity; minimal to no impact upon users labels Mar 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants