[MMI] Added code fences in whats new popup #19581

albertolive · 2023-06-13T15:00:03Z

Explanation

Adding the MMI portfolio notifications without disrupting much of the existing MM logic while at the same time having it prepared to add new MMI-specific notifications in the future. Added code fences to three existing files:

metamask-controller: We added our own notifications
whats-new-popup: We added new logic just for MMI
home-component: Added needed MMI prop

https://consensyssoftware.atlassian.net/browse/MMI-2503

Pre-merge author checklist

I've clearly explained:
- What problem this PR is solving
- How this problem was solved

Pre-merge reviewer checklist

Manual testing (e.g. pull and build branch, run in browser, test code being changed)
PR is linked to the appropriate GitHub issue

github-actions · 2023-06-13T15:00:17Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2023-06-14T09:15:41Z

Builds ready [b6f5462]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1836 ± 89 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	104	260	154	35	17
		domContentLoaded	1584	2214	1823	190	91
		load	1584	2214	1836	185	89
		domInteractive	1584	2214	1823	190	91

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 8 bytes
ui: -103 bytes
common: 0 bytes

codecov · 2023-06-14T09:15:52Z

Codecov Report

Merging #19581 (67a211e) into develop (ec4c405) will decrease coverage by 0.02%.
The diff coverage is 38.89%.

@@             Coverage Diff             @@
##           develop   #19581      +/-   ##
===========================================
- Coverage    69.85%   69.83%   -0.02%     
===========================================
  Files          980      981       +1     
  Lines        36909    36936      +27     
  Branches      9908     9911       +3     
===========================================
+ Hits         25782    25794      +12     
- Misses       11127    11142      +15

Impacted Files	Coverage Δ
.../components/app/whats-new-popup/whats-new-popup.js	`21.09% <20.00%> (-1.13%)`	⬇️
app/scripts/metamask-controller.js	`65.85% <50.00%> (+0.09%)`	⬆️
ui/pages/home/home.component.js	`44.28% <50.00%> (-0.22%)`	⬇️
shared/notifications/institutional/index.js	`66.67% <66.67%> (ø)`

ui/components/app/whats-new-popup/whats-new-popup.js

…mm-codebase # Conflicts: # ui/components/app/whats-new-popup/whats-new-popup.js

…mm-codebase

albertolive · 2023-06-23T13:03:03Z

@metamaskbot update-policies

metamaskbot · 2023-06-23T13:19:15Z

Policies updated

metamaskbot · 2023-06-23T13:49:34Z

Builds ready [e6788ee]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1714 ± 65 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	115	235	149	32	15
		domContentLoaded	1525	2042	1714	136	65
		load	1525	2043	1714	136	65
		domInteractive	1525	2042	1714	136	65

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 11 bytes
ui: -104 bytes
common: 60 bytes

brad-decker · 2023-06-23T14:04:26Z

ui/components/app/whats-new-popup/whats-new-popup.js

+
+          ///: BEGIN:ONLY_INCLUDE_IN(build-mmi)
+          renderNotification = renderFirstNotification;
+          ///: END:ONLY_INCLUDE_IN


So... this is an interesting optimization, but I don't think it would pass typescript safety. renderFirstNotification and renderSubsequentNotification have different arguments, so even though the additional parameters for renderFirstNotification are on the end of the function parameters it would fail to compile in typescript due to extra params existing. In order to make this work you should probably change both renderFirst and renderSubsequent take an options bag ({ notification, idRefMap }) instead of positional parameters. When you add jsdoc types to them, you can define a new type using @typedef for the options and pass that type as the type for the first parameter to each function. Even if you don't reference the 4 additional properties on renderFirst in renderSubsequent it would still type check.

Hi @brad-decker, I fixed this issue. Please verify that this is what you asked for.

…ons in order to bypass possible typsecript issues

…mm-codebase

albertolive · 2023-06-26T09:01:58Z

@metamaskbot update-policies

metamaskbot · 2023-06-26T09:12:51Z

No policy changes

…mm-codebase

metamaskbot · 2023-06-27T06:33:11Z

Builds ready [67a211e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1597 ± 39 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	114	169	140	18	8
		domContentLoaded	1439	1768	1597	82	39
		load	1439	1768	1597	82	39
		domInteractive	1439	1767	1597	82	39

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 11 bytes
ui: 35 bytes
common: 60 bytes

added code fences in whats new popup

907a9b7

albertolive requested a review from a team as a code owner June 13, 2023 15:00

albertolive requested a review from danjm June 13, 2023 15:00

albertolive added 2 commits June 14, 2023 10:20

Improved code

77a23e5

Added missing prop

b6f5462

zone-live previously approved these changes Jun 14, 2023

View reviewed changes

albertolive requested a review from brad-decker June 14, 2023 08:56

NidhiKJha reviewed Jun 22, 2023

View reviewed changes

ui/components/app/whats-new-popup/whats-new-popup.js Outdated Show resolved Hide resolved

brad-decker suggested changes Jun 22, 2023

View reviewed changes

ui/components/app/whats-new-popup/whats-new-popup.js Outdated Show resolved Hide resolved

Merge branch 'develop' into feature/MMI-3123-add-mmi-notification-to-…

2d7e6af

…mm-codebase # Conflicts: # ui/components/app/whats-new-popup/whats-new-popup.js

albertolive dismissed zone-live’s stale review via 2d7e6af June 23, 2023 09:48

albertolive requested review from NidhiKJha, brad-decker and zone-live June 23, 2023 09:48

NidhiKJha previously approved these changes Jun 23, 2023

View reviewed changes

Merge branch 'develop' into feature/MMI-3123-add-mmi-notification-to-…

d79677b

…mm-codebase

Update LavaMoat policies

e6788ee

metamaskbot dismissed NidhiKJha’s stale review via e6788ee June 23, 2023 13:19

metamaskbot requested review from a team as code owners June 23, 2023 13:19

brad-decker suggested changes Jun 23, 2023

View reviewed changes

albertolive added 2 commits June 26, 2023 10:42

updated functions by using an options object for the rendering functi…

73823c7

…ons in order to bypass possible typsecript issues

Merge branch 'develop' into feature/MMI-3123-add-mmi-notification-to-…

fce0248

…mm-codebase

albertolive requested a review from brad-decker June 26, 2023 08:44

albertolive requested a review from NidhiKJha June 26, 2023 08:44

zone-live approved these changes Jun 26, 2023

View reviewed changes

brad-decker approved these changes Jun 26, 2023

View reviewed changes

Merge branch 'develop' into feature/MMI-3123-add-mmi-notification-to-…

67a211e

…mm-codebase

albertolive merged commit 1e56fdb into develop Jun 27, 2023
54 of 56 checks passed

albertolive deleted the feature/MMI-3123-add-mmi-notification-to-mm-codebase branch June 27, 2023 06:30

github-actions bot locked and limited conversation to collaborators Jun 27, 2023

metamaskbot added the release-10.34.0 label Jun 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MMI] Added code fences in whats new popup #19581

[MMI] Added code fences in whats new popup #19581

albertolive commented Jun 13, 2023 •

edited

github-actions bot commented Jun 13, 2023

metamaskbot commented Jun 14, 2023

codecov bot commented Jun 14, 2023 •

edited

albertolive commented Jun 23, 2023

metamaskbot commented Jun 23, 2023

metamaskbot commented Jun 23, 2023

brad-decker Jun 23, 2023

albertolive Jun 26, 2023

brad-decker Jun 26, 2023

albertolive commented Jun 26, 2023

metamaskbot commented Jun 26, 2023

metamaskbot commented Jun 27, 2023

[MMI] Added code fences in whats new popup #19581

[MMI] Added code fences in whats new popup #19581

Conversation

albertolive commented Jun 13, 2023 • edited

Explanation

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jun 13, 2023

metamaskbot commented Jun 14, 2023

codecov bot commented Jun 14, 2023 • edited

Codecov Report

albertolive commented Jun 23, 2023

metamaskbot commented Jun 23, 2023

metamaskbot commented Jun 23, 2023

brad-decker Jun 23, 2023

Choose a reason for hiding this comment

albertolive Jun 26, 2023

Choose a reason for hiding this comment

brad-decker Jun 26, 2023

Choose a reason for hiding this comment

albertolive commented Jun 26, 2023

metamaskbot commented Jun 26, 2023

metamaskbot commented Jun 27, 2023

albertolive commented Jun 13, 2023 •

edited

codecov bot commented Jun 14, 2023 •

edited