-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate LavaMoat policies on each PR #19703
Merged
Merged
+8
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This depends upon #19589 |
Builds ready [8fc7f4e]
Page Load Metrics (1616 ± 59 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## develop #19703 +/- ##
========================================
Coverage 69.83% 69.83%
========================================
Files 979 979
Lines 36905 36905
Branches 9909 9909
========================================
Hits 25769 25769
Misses 11136 11136 |
The LavaMoat policies are now validated on every PR. This makes it easier to validate policy changes, as they should always correspond with the changes made in the PR (unlike today, when they could be due to a change in platform or a previous PR). Closes #19680
Gudahtt
force-pushed
the
validate-lavamoat-policies-on-each-pr
branch
from
June 22, 2023 21:11
8fc7f4e
to
b252a3d
Compare
@metamaskbot update-policies |
This comment was marked as outdated.
This comment was marked as outdated.
Policies updated |
Builds ready [b1b773d]
Page Load Metrics (1482 ± 38 ms)
Bundle size diffs
|
Mrtenz
approved these changes
Jun 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
danjm
approved these changes
Jun 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The LavaMoat policies are now validated on every PR. This makes it easier to validate policy changes, as they should always correspond with the changes made in the PR (unlike today, when they could be due to a change in platform or a previous PR).
Closes #19680
Manual Testing Steps
The LavaMoat validation should be running on this PR
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.