Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate LavaMoat policies on each PR #19703

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jun 21, 2023

Explanation

The LavaMoat policies are now validated on every PR. This makes it easier to validate policy changes, as they should always correspond with the changes made in the PR (unlike today, when they could be due to a change in platform or a previous PR).

Closes #19680

Manual Testing Steps

The LavaMoat validation should be running on this PR

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@Gudahtt
Copy link
Member Author

Gudahtt commented Jun 21, 2023

This depends upon #19589

@metamaskbot
Copy link
Collaborator

Builds ready [8fc7f4e]
Page Load Metrics (1616 ± 59 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint99145123136
domContentLoaded14261797159611354
load14261888161612259
domInteractive14261797159611354
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #19703 (b1b773d) into develop (492038a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #19703   +/-   ##
========================================
  Coverage    69.83%   69.83%           
========================================
  Files          979      979           
  Lines        36905    36905           
  Branches      9909     9909           
========================================
  Hits         25769    25769           
  Misses       11136    11136           

Base automatically changed from parallel-validate-lavamoat-config to develop June 22, 2023 21:10
The LavaMoat policies are now validated on every PR. This makes it
easier to validate policy changes, as they should always correspond
with the changes made in the PR (unlike today, when they could be due
to a change in platform or a previous PR).

Closes #19680
@Gudahtt Gudahtt force-pushed the validate-lavamoat-policies-on-each-pr branch from 8fc7f4e to b252a3d Compare June 22, 2023 21:11
@Gudahtt Gudahtt marked this pull request as ready for review June 22, 2023 21:11
@Gudahtt Gudahtt requested review from a team, kumavis and brad-decker as code owners June 22, 2023 21:11
@Gudahtt
Copy link
Member Author

Gudahtt commented Jun 22, 2023

@metamaskbot update-policies

@metamaskbot

This comment was marked as outdated.

@metamaskbot
Copy link
Collaborator

Policies updated

@metamaskbot metamaskbot requested review from a team as code owners June 22, 2023 21:42
@metamaskbot
Copy link
Collaborator

Builds ready [b1b773d]
Page Load Metrics (1482 ± 38 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint992051232211
domContentLoaded1355163114827838
load1355163214827838
domInteractive1354163114827838
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

Copy link
Member

@Mrtenz Mrtenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@Gudahtt Gudahtt merged commit 3b9fd43 into develop Jun 23, 2023
57 checks passed
@Gudahtt Gudahtt deleted the validate-lavamoat-policies-on-each-pr branch June 23, 2023 12:20
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve LavaMoat policy validation
4 participants