Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(action): add required permissions to remove labels #19728

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

gauthierpetetin
Copy link
Contributor

@gauthierpetetin gauthierpetetin commented Jun 22, 2023

Explanation

Tiny fix: The Github action didn't have sufficient permissions to remove labels from issues or PRs.

Screenshots/Screencaps

NA

Before

We currently have this error when the action is executed:

{
  "message": "Resource not accessible by integration",
  "documentation_url": "https://docs.github.com/rest/reference/issues#remove-a-label-from-an-issue"
}

After

No more error.

To reproduce:

  1. Add "needs-dev-review" label on PR
  2. Merge the PR
  3. Label shall be removed a few seconds after PR is merged

Pre-merge author checklist

  • [ x ] I've clearly explained:
    • [ x ] What problem this PR is solving
    • [ x ] How this problem was solved
    • [ x ] How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gauthierpetetin gauthierpetetin added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 22, 2023
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [ddea807]
Page Load Metrics (1537 ± 27 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint111176133168
domContentLoaded1432163015375727
load1432163015375727
domInteractive1432163015375727
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #19728 (ddea807) into develop (492038a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #19728   +/-   ##
========================================
  Coverage    69.83%   69.83%           
========================================
  Files          979      979           
  Lines        36905    36905           
  Branches      9909     9909           
========================================
  Hits         25769    25769           
  Misses       11136    11136           

@gauthierpetetin gauthierpetetin merged commit ad3140c into develop Jun 23, 2023
54 checks passed
@gauthierpetetin gauthierpetetin deleted the fix_remove_labels_2 branch June 23, 2023 12:27
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants