Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Storybook docs colors not updating with Themes #19730

Closed
wants to merge 1 commit into from

Conversation

Jainex17
Copy link
Contributor

Explanation

In the Storybook documentation, there was a bug causing colors to not update when switching themes. Specifically, the text color was not rendering properly for the dark theme when it was set to the default color.

Change Made

  1. In the ./colors.scss file, the value of --color-text-default was set to white, which was causing the problem. I replaced this value with --brand-colors-grey-grey600, which resolved the issue.

Additionally, I took care to ensure that this change does not impact other components or functionalities of the system.

Screenshots/Screencaps

Before

After

Manual Testing Steps

  • Navigate to the Storybook Component Library.
  • Within the ComponentLibrary, locate and access the Text component.
  • Open the documentation section for the Text component.
  • Switch the theme to the dark mode.
  • Observe the colors in the documentation and verify that they update correctly according to the selected dark theme.
  • Specifically, pay attention to the text color when it is set to the default value, ensuring it renders properly in the dark mode.

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

@Jainex17 Jainex17 requested a review from a team as a code owner June 23, 2023 06:42
@Jainex17 Jainex17 requested a review from danjm June 23, 2023 06:42
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jun 23, 2023
@georgewrmarshall georgewrmarshall removed the request for review from danjm June 23, 2023 21:10
@georgewrmarshall
Copy link
Contributor

georgewrmarshall commented Jun 23, 2023

Hi @Jainex17, thanks for your contribution but we do not want to update the CSS here I think the solution should be something to do with storybook and the dark mode storybook plugin hipstersmoothie/storybook-dark-mode#180

@georgewrmarshall georgewrmarshall removed the team-design-system All issues relating to design system in Extension label Jun 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2023
@Jainex17 Jainex17 deleted the Sb-not-updating-Themes branch June 27, 2023 09:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Storybook docs colors are not updated with Themes
2 participants