Bug Fix: Storybook docs colors not updating with Themes #19730
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
In the Storybook documentation, there was a bug causing colors to not update when switching themes. Specifically, the text color was not rendering properly for the dark theme when it was set to the default color.
Change Made
./colors.scss
file, the value of--color-text-default
was set to white, which was causing the problem. I replaced this value with--brand-colors-grey-grey600
, which resolved the issue.Additionally, I took care to ensure that this change does not impact other components or functionalities of the system.
Screenshots/Screencaps
Before
After
Manual Testing Steps
ComponentLibrary
, locate and access theText
component.Text
component.Pre-merge author checklist
Pre-merge reviewer checklist