Adding alerts for transaction inside deprecation

[jpuri]

Description

Add transaction insight deprecation notice

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change.

Related issues

_Fixes MetaMask/MetaMask-planning#1326

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained:
  • What problem this PR is solving.
  • How this problem was solved.
  • How reviewers can test my changes.
• I’ve indicated what issue this PR is linked to: Fixes #???
• I’ve included tests if applicable.
• I’ve documented any added code.
• I’ve applied the right labels on the PR (see labeling guidelines).
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5ca6dee) 68.64% compared to head (3a6321e) 68.64%.
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #21193   +/-   ##
========================================
  Coverage    68.64%   68.64%           
========================================
  Files         1017     1018    +1     
  Lines        40788    40791    +3     
  Branches     10896    10896           
========================================
+ Hits         27997    28000    +3     
  Misses       12791    12791           

Files	Coverage Δ
ui/components/app/confirm-data/confirm-data.js	93.75% <100.00%> (ø)
...irm-data/transaction-insights-deprecation-alert.js	100.00% <100.00%> (ø)
...details/transaction-list-item-details.component.js	62.82% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [3a6321e]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5, 6
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (833 ± 392 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	85	138	102	14	7
		domContentLoaded	66	139	91	15	7
		load	77	1883	833	817	392
		domInteractive	66	139	91	15	7

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 0 Bytes (0.00%)
• ui: 2.22 KiB (0.03%)
• common: 183 Bytes (0.00%)

[digiwand]

[nit] we can move `className="confirm-data" to the parent Box element to follow the pattern we have in our codebase. This would also require us to update one of the styles

& > .disclosure { → & .disclosure { (or specifying a new classname)

[jpuri]

This is existing div only wrapped in a parent element and an alert placed on top of it. I would avoid refactoring it and functionality is being deprecated.

[FrederikBolding]

Yeah, I don't think there is much reason to spend time maintaining this if we are gonna remove it in a couple of releases.

[FrederikBolding]

Code LGTM, but is it intentional that it doesn't match the designs? @jpuri

Designs has the deprecation alert at the bottom but here it is implemented at the top 🤔

EDIT: My bad, the screenshots on the issue were out of date.