Change window title from "MetaMask Notification" to "MetaMask Dialog"

[eriknson]

Description

Changes the window title from MetaMask Notification to MetaMask Dialog

Manual testing steps

1. Prompt any MetaMask window / popup
2. Confirm that the window's title is "MetaMask Dialog"

[HowardBraham]

This isn't passing the E2E tests, and I don't think it could. The problem is that the main window is also called "MetaMask." Why do you want to change the window title anyway?

[eriknson]

This isn't passing the E2E tests, and I don't think it could. The problem is that the main window is also called "MetaMask."

I see, will try to figure this out.

Why do you want to change the window title anyway?

We're introducing notifications (natively and via snaps) so it'll be confusing if this is also called "Notification"

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a6b592d) 67.74% compared to head (ad45cf5) 67.74%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #21680   +/-   ##
========================================
  Coverage    67.74%   67.74%           
========================================
  Files         1054     1054           
  Lines        40844    40844           
  Branches     10945    10945           
========================================
  Hits         27669    27669           
  Misses       13175    13175           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [ad45cf5]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5, 6
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1346 ± 128 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	84	304	171	69	33
		domContentLoaded	9	219	65	78	38
		load	827	1740	1346	268	128
		domInteractive	9	219	65	78	38

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[bowensanders]

LGTM! :)