Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: currency preferences toggle not displayed #21985

Merged
merged 1 commit into from
Nov 23, 2023
Merged

fix: currency preferences toggle not displayed #21985

merged 1 commit into from
Nov 23, 2023

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Nov 23, 2023

Description

when the user goes to settings to change the primary currency symbol, the native token symbol is not displayed correctly ( see photo below )

Manual testing steps

  1. go to the develop branch
  2. go to settings
  3. find the primary currency symbol
  4. fiat is displayed correctly as long as the native token symbol is not displayed

Screenshots/Recordings

Before

Screenshot 2023-11-22 at 10 32 38

After

Screenshot 2023-11-23 at 14 31 03

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb added the team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead label Nov 23, 2023
@salimtb salimtb requested a review from a team as a code owner November 23, 2023 13:32
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 23, 2023
@@ -18,11 +18,12 @@ const mapStateToProps = (state, ownProps) => {
} = state;
const {
currentCurrency,
nativeCurrency,
providerConfig: { ticker: nativeCurrency },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after changes on the controller , nativeCurrency is removed from state.metamask.
it was replaced everywhere with the ticker value got from providerConfig ( e.g: getNativeCurrency function ) but it seems to have been forgotten to replace it at this level too.
and this is why we have this bug

@metamaskbot
Copy link
Collaborator

Builds ready [5cc1a21]
Page Load Metrics (521 ± 302 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint881511192210
domContentLoaded67143101199
load801577521630302
domInteractive67143101199
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 9 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@salimtb salimtb requested a review from danjm November 23, 2023 14:17
@salimtb salimtb removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 23, 2023
@salimtb salimtb merged commit f4b893a into develop Nov 23, 2023
67 of 68 checks passed
@salimtb salimtb deleted the MMASSETS-99 branch November 23, 2023 15:17
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2023
@metamaskbot metamaskbot added the release-11.7.0 Issue or pull request that will be included in release 11.7.0 label Nov 23, 2023
@salimtb salimtb added the regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead label Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead release-11.7.0 Issue or pull request that will be included in release 11.7.0 team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants