-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: currency preferences toggle not displayed #21985
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
@@ -18,11 +18,12 @@ const mapStateToProps = (state, ownProps) => { | |||
} = state; | |||
const { | |||
currentCurrency, | |||
nativeCurrency, | |||
providerConfig: { ticker: nativeCurrency }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after changes on the controller , nativeCurrency
is removed from state.metamask
.
it was replaced everywhere with the ticker
value got from providerConfig
( e.g: getNativeCurrency
function ) but it seems to have been forgotten to replace it at this level too.
and this is why we have this bug
Builds ready [5cc1a21]
Page Load Metrics (521 ± 302 ms)
Bundle size diffs
|
Description
when the user goes to settings to change the primary currency symbol, the native token symbol is not displayed correctly ( see photo below )
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist