Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MMI] allow for non custodial accounts to cancel and speed up #22164

Conversation

zone-live
Copy link
Contributor

Description

We want to enable the CancelSpeedupPopover for non custodial accounts, this PR allows for that and removes an unnecessary code fence, since by checking for !isCustodian will always return the CancelSpeedupPopover for the main MM as well.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@zone-live zone-live added the team-mmi PRs from the MMI team label Dec 5, 2023
@zone-live zone-live requested a review from a team as a code owner December 5, 2023 12:26
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5ee10d3) 67.71% compared to head (099c419) 67.71%.

Files Patch % Lines
...ction-list-item/transaction-list-item.component.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #22164      +/-   ##
===========================================
- Coverage    67.71%   67.71%   -0.00%     
===========================================
  Files         1053     1053              
  Lines        40875    40877       +2     
  Branches     10950    10951       +1     
===========================================
+ Hits         27676    27677       +1     
- Misses       13199    13200       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 5, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@zone-live zone-live merged commit b7236ba into develop Dec 5, 2023
69 checks passed
@zone-live zone-live deleted the MMI-4236-allow-for-non-custodial-accounts-to-cancel-and-speed-up branch December 5, 2023 14:13
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
@metamaskbot metamaskbot added the release-11.8.0 Issue or pull request that will be included in release 11.8.0 label Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.8.0 Issue or pull request that will be included in release 11.8.0 team-mmi PRs from the MMI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants