Enable ppom by default

[jpuri]

Description

Blockaid validations should be enabled by default for all users.

Related issues

Fixes: metamask-planning#1762

Manual testing steps

1. Create a new account
2. Blockaid validations should be enabled by default for the account

Screenshots/Recordings

NA

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[seaona]

[Update] The 2 tests are failing because they are reversed now. The default state (without going to settings) is now Blockaid enabled, and going to settings and toggling the button makes the feature disabled

• [PPOM Settings @no-mmi should show the PPOM warning when the toggle is on
• [PPOM Settings @no-mmi should not show the PPOM warning when toggle is off

[jpuri]

[Update] The 2 tests are failing because they are reversed now. The default state (without going to settings) is now Blockaid enabled, and going to settings and toggling the button makes the feature disabled

• [PPOM Settings @no-mmi should show the PPOM warning when the toggle is on
• [PPOM Settings @no-mmi should not show the PPOM warning when toggle is off

Yep @seaona I just updated those

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (10d40aa) 67.78% compared to head (32db1b5) 67.96%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #22246      +/-   ##
===========================================
+ Coverage    67.78%   67.96%   +0.18%     
===========================================
  Files         1065     1066       +1     
  Lines        41275    41286      +11     
  Branches     11066    11067       +1     
===========================================
+ Hits         27978    28059      +81     
+ Misses       13297    13227      -70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [32db1b5]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5, 6
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1360 ± 145 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	87	306	166	60	29
		domContentLoaded	9	206	59	67	32
		load	893	1910	1360	303	145
		domInteractive	9	206	59	67	32

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 748 Bytes (0.02%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)