-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ppom by default #22246
Enable ppom by default #22246
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
[Update] The 2 tests are failing because they are reversed now. The default state (without going to settings) is now Blockaid enabled, and going to settings and toggling the button makes the feature disabled
|
…-extension into enable_ppom_by_default
Yep @seaona I just updated those |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #22246 +/- ##
===========================================
+ Coverage 67.78% 67.96% +0.18%
===========================================
Files 1065 1066 +1
Lines 41275 41286 +11
Branches 11066 11067 +1
===========================================
+ Hits 27978 28059 +81
+ Misses 13297 13227 -70 ☔ View full report in Codecov by Sentry. |
Builds ready [32db1b5]
Page Load Metrics (1360 ± 145 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
Blockaid validations should be enabled by default for all users.
Related issues
Fixes: metamask-planning#1762
Manual testing steps
Screenshots/Recordings
NA
Pre-merge author checklist
Pre-merge reviewer checklist