Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pending txs to tx list #224

Merged
merged 9 commits into from
May 26, 2016
Merged

Add pending txs to tx list #224

merged 9 commits into from
May 26, 2016

Conversation

danfinlay
Copy link
Contributor

A few notes:

  • Signed messages are not currently persisted, so after they're approved, they leave the list. I believe this was a conscious design decision we made, but I can't find the rationale. I think we might want to add persisting of signed messages for review.
  • I've been hitting some out of gas errors, but I don't think it's associated with this branch.
  • When first refreshing the plugin, when a site requests web3.eth.sign, it first reloads the page as if we switched providers. This only happens on the first sign request.

@kumavis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant