fix: IPFS NFTs fetching

[bergeron]

Description

Problem: With IPFS gateway=on and Display NFT media=on, manually imported IPFS NFT render blank.

Diagnosis: NftController checks isIpfsGatewayEnabled, but this value was always undefined even with the setting enabled in extension. I'm not sure why the field was present in core's preferences controller but not extension's.

Solution: Update extension to toggle isIpfsGatewayEnabled preference

Before:

Screen.Recording.2024-01-25.at.1.07.10.PM.mov

After:

Screen.Recording.2024-01-25.at.12.57.29.PM.mov

Related issues

Fixes:

Manual testing steps

1. Set IPFS gateway=on and Display NFT media=on
2. manually import an IPFS NFT (e.g. 0xee79a3e8aef1109a6ee82bf399ce9e1bd43cf5c4 on polygon)
3. it should render

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov]

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (e98039c) 68.46% compared to head (71f3364) 68.10%.

❗ Current head 71f3364 differs from pull request most recent head 3500a28. Consider uploading reports for the commit 3500a28 to get more accurate results

Files	Patch %	Lines
app/scripts/controllers/preferences.js	16.67%	5 Missing ⚠️
ui/store/actions.ts	66.67%	2 Missing ⚠️
...ponents/app/nft-default-image/toggle-ipfs-modal.js	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #22627      +/-   ##
===========================================
- Coverage    68.46%   68.10%   -0.37%     
===========================================
  Files         1088     1091       +3     
  Lines        42825    42928     +103     
  Branches     11394    11411      +17     
===========================================
- Hits         29319    29232      -87     
- Misses       13506    13696     +190     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [71f3364]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5, 6, 7
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (782 ± 41 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	94	174	112	18	8
		domContentLoaded	9	57	17	10	5
		load	702	1065	782	85	41
		domInteractive	9	57	17	10	5

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 188 Bytes (0.01%)
• ui: 442 Bytes (0.01%)
• common: 24 Bytes (0.00%)

[davidmurdoch]

LGTM (with one suggestion/nit)

[metamaskbot]

Builds ready [3500a28]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5, 6, 7
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (803 ± 22 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	84	162	114	18	8
		domContentLoaded	9	49	17	8	4
		load	729	920	803	46	22
		domInteractive	9	48	17	8	4

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 188 Bytes (0.01%)
• ui: 442 Bytes (0.01%)
• common: 24 Bytes (0.00%)