Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snaps E2E] Update enums.js to newest test-snaps version #22893

Closed
wants to merge 1 commit into from

Conversation

bowensanders
Copy link
Contributor

Description

This updates the enums.js file to use the latest test-snaps. This adds support for client-status and the new, faster 10-second cronjob snap.

Related issues

Fixes:

Manual testing steps

  1. Go to the newest test-snaps page
  2. Check to see that Client Status Snap exists.
  3. Check timing on loading the Cronjob test snap. It should fire every 10 seconds.

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bowensanders bowensanders added area-snaps team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead labels Feb 9, 2024
@bowensanders bowensanders self-assigned this Feb 9, 2024
@bowensanders bowensanders requested a review from a team as a code owner February 9, 2024 19:04
Copy link
Contributor

github-actions bot commented Feb 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@FrederikBolding
Copy link
Member

Blocked and superseded by #22828

I think we can close this @bowensanders

@bowensanders
Copy link
Contributor Author

closed per request

@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2024
@bowensanders bowensanders deleted the bowen/cronjobspeed branch February 14, 2024 18:46
@ziedbrini ziedbrini added team-snaps-platform Snaps Platform team and removed team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead labels Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants