Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MMI] 4564 - fix the way get custody type was being done #22950

Merged
merged 4 commits into from Feb 19, 2024

Conversation

zone-live
Copy link
Contributor

Description

We were hardcoding the custody type to always be JSON-RPC, but in reality it can be also ECA3, or a legacy custodian such as Qredo. Therefore we now get this value the correct way.

Ref ticket

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@zone-live zone-live added the team-mmi PRs from the MMI team label Feb 14, 2024
@zone-live zone-live requested a review from a team as a code owner February 14, 2024 16:05
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (12a0770) 68.54% compared to head (055830e) 68.54%.
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #22950      +/-   ##
===========================================
- Coverage    68.54%   68.54%   -0.00%     
===========================================
  Files         1088     1088              
  Lines        42904    42905       +1     
  Branches     11413    11414       +1     
===========================================
  Hits         29408    29408              
- Misses       13496    13497       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [055830e]
Page Load Metrics (1042 ± 52 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1234701867034
domContentLoaded874342311
load8451403104210852
domInteractive874342311
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@zone-live zone-live merged commit 0cc816e into develop Feb 19, 2024
65 checks passed
@zone-live zone-live deleted the MMI-4565-get-custodyType-value branch February 19, 2024 12:23
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2024
@metamaskbot metamaskbot added the release-11.12.0 Issue or pull request that will be included in release 11.12.0 label Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.12.0 Issue or pull request that will be included in release 11.12.0 team-mmi PRs from the MMI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants