New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MMI] 4564 - fix the way get custody type was being done #22950
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #22950 +/- ##
===========================================
- Coverage 68.54% 68.54% -0.00%
===========================================
Files 1088 1088
Lines 42904 42905 +1
Branches 11413 11414 +1
===========================================
Hits 29408 29408
- Misses 13496 13497 +1 ☔ View full report in Codecov by Sentry. |
Builds ready [055830e]
Page Load Metrics (1042 ± 52 ms)
Bundle size diffs
|
albertolive
approved these changes
Feb 15, 2024
NidhiKJha
approved these changes
Feb 19, 2024
metamaskbot
added
the
release-11.12.0
Issue or pull request that will be included in release 11.12.0
label
Feb 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-11.12.0
Issue or pull request that will be included in release 11.12.0
team-mmi
PRs from the MMI team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were hardcoding the custody type to always be
JSON-RPC
, but in reality it can be alsoECA3
, or a legacy custodian such asQredo
. Therefore we now get this value the correct way.Ref ticket
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist