test: optimize memory usage when building storybook by using swc #22975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
HowardBraham
force-pushed
the
fix-storybook-mem-issue
branch
from
383253e
to
efa54b4
Compare
Builds ready [efa54b4]
Page Load Metrics (1971 卤 233 ms)
Bundle size diffs
|
| @@ -45,7 +45,7 @@ const LogoItem = ({ Component }) => { | |||
| backgroundColor={BackgroundColor.backgroundDefault} | |||
| > | |||
| <Box marginBottom={2}>{Component}</Box> | |||
| <Text>{`${Component.type.__docgenInfo.displayName}`}</Text> | |||
| <Text>{`${Component.type.name}`}</Text> | |||
| </Card> | |||
There was a problem hiding this comment.
Was this just deprecated? Don't see any visual changes
There was a problem hiding this comment.
I'm not completely sure, but once @davidmurdoch turned on useSWC, this stopped working without changing Component.type.__docgenInfo.displayName to Component.type.name.
georgewrmarshall
approved these changes
Feb 15, 2024
davidmurdoch
changed the title
HowardBraham
approved these changes
Feb 15, 2024
metamaskbot
added
the
release-11.12.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building storybook in CI seems to fail often -- probably due to running out of memory. Changing the compiler to swc might help (according to storybookjs/storybook#6408 (comment)).
I don't know what the ramifications of this change may be (I don't even know what storybook is for 馃槄). So someone with knowledge here should review this PR.